Store request IDs as bytes; add 'inferred' to Thing #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjpwalker
commented
Apr 7, 2021
| # | ||
|
|
||
| build --incompatible_strict_action_env --javacopt='--release 8' | ||
| build --incompatible_strict_action_env --java_language_version=11 --javacopt='--release 11' |
Member
Author
There was a problem hiding this comment.
See typedb/typedb#6281 - after installing the newest Bazel (by pulling grakn and building it locally) I was no longer able to build protocol. I fixed it by upgrading Bazel and Java in protocol.
alexjpwalker
changed the title
alexjpwalker
commented
Apr 7, 2021
| Thing.SetHas.Req thing_set_has_req = 103; | ||
| Thing.UnsetHas.Req thing_unset_has_req = 104; | ||
| Thing.GetRelations.Req thing_get_relations_req = 105; | ||
| Thing.GetPlaying.Req thing_get_playing_req = 106; |
Member
Author
There was a problem hiding this comment.
Note that moving these around breaks compatibility with older clients - maybe this is a practice we want to abolish going forward?
haikalpribadi
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Previously the field
req_idof a transaction request was stored as a string, which is an inefficient representation of a UUID. We've changed it to bytes.Also, we deleted
IsInferredand added theinferredflag toThing, allowing clients to check if a Thing is inferred without an additional network roundtrip.What are the changes implemented in this PR?
Store request IDs as bytes, not strings (fixes #134 )
Add 'inferred' to Thing (fixes typedb/typedb-driver#314 )