Add protobuf schema for Raft's 'state mutation request' #232
Conversation
| // TODO: If the protocol is exposed, maybe it's actually `TypeDBRaft`? | ||
| service Raft { | ||
| rpc replication (Replication.Req) returns (Replication.Res); | ||
| rpc request (Request) returns (Request); |
There was a problem hiding this comment.
Without registering the endpoint, the Request message doesn't trigger code-generation. Find out why.
| deps = [], | ||
| ) | ||
|
|
||
| proto_library( |
There was a problem hiding this comment.
Let's add these libs in all languages. Moreover, I remember that there is another place where you need to list all the proto files, please search for replication-proto and replication.proto usages. I might be wrong.
But this might be the reason why it does not build these files without introducing them into the service.
There was a problem hiding this comment.
Stop checking Github on your holiday bro
farost
left a comment
farost
left a comment
There was a problem hiding this comment.
Let's make sure we propagate the new file/target everywhere. Looks good overall
|
Merged after fixing the reported issue. Please have a look at this PR in more detail once you're back from the holiday, @farost ! |
Add protobuf schema for Raft's 'state mutation request'. The schema defines how the data is transported over the network and stored in the Raft log. - Add a protobuf definition for State Mutation Request - Create a mock RPC endpoint to handle that message as a hack to get the code generator to work
Add protobuf schema for Raft's 'state mutation request'. The schema defines how the data is transported over the network and stored in the Raft log. - Add a protobuf definition for State Mutation Request - Create a mock RPC endpoint to handle that message as a hack to get the code generator to work
Release notes: usage and product changes
Add protobuf schema for Raft's 'state mutation request'. The schema defines how the data is transported over the network and stored in the Raft log.
Implementation