Run pyrefly over test cases #2914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Nov 25, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Awesome! Thanks a lot!
Having more typecheckers is totally a great thing for the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
This PR proposes running the pyrefly type checker (which I am a maintainer of) over the assert_type tests. Pyrefly has built-in django support that uses django-stubs, and running pyrefly over these tests to make sure it stays compatible with the stubs would be helpful for us.
Notes:
# type: ignorecomments and added# pyrefly: ignorecomments where needed, following what was done for pyright.test_enums.py, I've changed some of theassert_types to accept both mypy and pyrefly's output, in cases in which both look reasonable to me. Happy to revert this change if the preference is to keep mypy's output as the source of truth.Related issues
Refs #579