Skip to content

Add missing allow_empty arg to ManyRelatedField #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

Add missing allow_empty arg to ManyRelatedField #322

merged 1 commit into from
Jan 19, 2023

Conversation

@guldfisk
Copy link
Contributor

Closes #321

intgr
intgr approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@intgr intgr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For changes like these, there's no need to bother creating an issue, just a PR is fine.

@intgr intgr force-pushed the fix_missing_allow_empty_on_many_related_field branch from acf8347 to 1d3a873 Compare January 19, 2023 14:28
@intgr
Copy link
Contributor

intgr commented Jan 19, 2023

Thanks! CI passed after rebasing.

Looking at DRF code, I noticed that allow_empty can only be passed as a kwarg.

If you're up for it, would be nice to add *, separating positional and keyword-only arguments: https://peps.python.org/pep-3102/ Requires some reverse engineering in DRF code though.

@intgr intgr merged commit 7d8dbc1 into typeddjango:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@intgr intgr intgr approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow_empty arg missing from ManyRelatedField

2 participants

@guldfisk @intgr