Skip to content

Conversation

@cquiroz
Copy link
Contributor

@cquiroz cquiroz commented Jul 14, 2017

This is a small change that would default to build with scala.js 0.6.18 but would also easily allow for building with 1.0.0-M1. Id like to get scalacheck published up to 1.0.0-M1 to let other projects that depend on scalacheck also build on 1.0.0-M1, e.g. scalatest

@cquiroz cquiroz force-pushed the scala.js-0.6.18-1.0.0-M1 branch from 739f99b to 79ecd1e Compare July 14, 2017 19:22
@rickynils
Copy link
Contributor

Superseded by #348. Also, I'm not sure about injecting the scalajs version through the environment. Maybe it is a good idea, but I have to think about it.

@rickynils rickynils closed this Aug 16, 2017
@cquiroz
Copy link
Contributor Author

cquiroz commented Aug 16, 2017

The use of variable is suggested by scala.js at
https://www.scala-js.org/news/2017/07/03/announcing-scalajs-1.0.0-M1/

as the way to cross compile across scala.js major versions

It would be useful to get scalacheck on 1.0.0-M1 to port scalatest among other things, see
scalatest/scalatest#1182

@andreaTP
Copy link

Actually #348 does not supersede this PR, I do not understand why it has been closed and not actioned.
@rickynils could you please take in consideration to reopen and accept it? Thanks in advance

About the use of Env variables it is suggested here: https://www.scala-js.org/news/2017/07/03/announcing-scalajs-1.0.0-M1/

If it is blocking scalatest to be ported is an important issue for all Scala.Js ecosystem cc. @sjrd

@rickynils
Copy link
Contributor

@cquiroz Can you rebase this PR so I can merge it?

@cquiroz cquiroz force-pushed the scala.js-0.6.18-1.0.0-M1 branch from 79ecd1e to 3268050 Compare August 23, 2017 12:12
@cquiroz
Copy link
Contributor Author

cquiroz commented Aug 23, 2017

Rebased. When you publish please remember to publish for both scala.js versions

@cquiroz cquiroz changed the title Added support to build on scala.js 0.6.18 and 1.0.0-M1 Added support to build on scala.js 1.0.0-M1 Aug 23, 2017
@andreaTP
Copy link

thanks a lot @rickynils and @cquiroz

@rickynils rickynils merged commit c59ae70 into typelevel:master Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants