Skip to content

Conversation

@armanbilge
Copy link
Member

So this is fun! All tests are passing :) but a couple notes:

  1. The build is still a bit hacked, relying on some bootleg deps (enumeratum, natchez, etc.).
  2. I made some minor breaking changes and bumped the base version. With some platforming ugliness this could be avoided.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #703 (3c67115) into main (f41b328) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 3c67115 differs from pull request most recent head af779fe. Consider uploading reports for the commit af779fe to get more accurate results

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   87.08%   87.16%   +0.07%     
==========================================
  Files         110      111       +1     
  Lines        1487     1504      +17     
  Branches      105      107       +2     
==========================================
+ Hits         1295     1311      +16     
- Misses        192      193       +1     
Impacted Files Coverage Δ
.../src/main/scala/net/protocol/StartupPlatform.scala 94.11% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tpolecat
Copy link
Member

holy crap

@armanbilge armanbilge closed this Oct 31, 2022
@armanbilge armanbilge reopened this Oct 31, 2022
@armanbilge armanbilge closed this Oct 31, 2022
@armanbilge armanbilge reopened this Oct 31, 2022
@mpilquist mpilquist marked this pull request as ready for review November 20, 2022 19:49
@mpilquist mpilquist closed this Nov 20, 2022
@mpilquist mpilquist reopened this Nov 20, 2022
build.sbt Outdated
)
.platformsSettings(JVMPlatform, JSPlatform)(
libraryDependencies ++= Seq(
"com.beachape" %%% "enumeratum" % "1.7.1-SNAPSHOT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to be a snapshot now that's it's moved to JVM/JS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see that was changed in a subsequent commit.

@mpilquist mpilquist merged commit 456ade1 into typelevel:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants