Update to Scala 3.2.0 #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executed command: sbt githubWorkflowGenerate
armanbilge
commented
Oct 31, 2022
| case _ => | ||
| report.error(s"StringContext arguments must be literals.") | ||
| return '{???} | ||
| Left('{ compiletime.error(s"StringContext arguments must be literals.") }) |
Member
Author
There was a problem hiding this comment.
Non-local returns are deprecated, so I refactored this macro to use Either for short-circuiting.
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 85.00% 85.00%
=======================================
Files 124 124
Lines 1647 1647
Branches 130 130
=======================================
Hits 1400 1400
Misses 247 247 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be non-trivial due to deprecations and warnings.