Separating the test artifact #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Drafting until upstream finalizes... |
|
@armanbilge fiy the scala-cli feature was merged and should be released very soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll leave this in draft for now:Nvm, I opened it as a standard PR by mistake :PIt's a test, and we need to check whether maven central will need some mangling to let us upload the artifact.
Also, one thing to note is that
toolkit-testdoesn't depend ontoolkit. This was done due to some discussions in the toolkit repo.TLDR: the behaviour should be that scala-cli will add both the artifacts if the directive
//> using test.toolkit latestis used in a test file.Lastly, the site will need some updates to mention the 2 artifacts and instructions if this gets merged.
Closes #30.