Create roles #75
Closed
Create roles #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@allcontributors please add @kamiloox for code |
Contributor
|
@mmiszy I've put up a pull request to add @kamiloox! 🎉 |
typeofweb
requested changes
Jan 7, 2022
src/roles/roles.ts
Outdated
| const removeMembersRoles = async (role: Role) => { | ||
| const membersWithRole = role?.members; | ||
|
|
||
| if (membersWithRole) await Promise.all(membersWithRole.map((member) => removeRole(member, role))); |
Member
There was a problem hiding this comment.
Suggested change
| if (membersWithRole) await Promise.all(membersWithRole.map((member) => removeRole(member, role))); | |
| if (membersWithRole) { | |
| return Promise.all(membersWithRole.map((member) => removeRole(member, role))); | |
| } |
src/roles/roles.ts
Outdated
| type Role = Discord.Role | undefined; | ||
|
|
||
| const createKarmaRole = async (guild: Guild) => { | ||
| await guild?.roles.create({ |
Member
There was a problem hiding this comment.
Suggested change
| await guild?.roles.create({ | |
| return guild.roles.create({ |
src/roles/roles.ts
Outdated
|
|
||
| type Role = Discord.Role | undefined; | ||
|
|
||
| const createKarmaRole = async (guild: Guild) => { |
Member
There was a problem hiding this comment.
Suggested change
| const createKarmaRole = async (guild: Guild) => { | |
| const createKarmaRole = (guild: Discord.Guild) => { |
src/roles/roles.ts
Outdated
| }; | ||
|
|
||
| const fetchKarmaRole = async (guild: Guild) => { | ||
| return guild && (await guild?.roles.fetch()).cache.find((role) => role.name === ROLE_NAME); |
Member
There was a problem hiding this comment.
Czemu wszędzie guild ma typ | undefined? Nie podoba mi się to
src/roles/roles.ts
Outdated
Comment on lines
36
to
38
| if (!role) await createKarmaRole(guild); | ||
| else return role; | ||
| return await fetchKarmaRole(guild); |
Member
There was a problem hiding this comment.
Ten return await fetchKarmaRole nigdy się nie wykona, no nie? :P
src/roles/roles.ts
Outdated
Comment on lines
44
to
46
| if (!member) console.error(`Member with id ${memberId} doesn't exists!`); | ||
| if (!role) console.error(`Role for karma doesn't exists`); | ||
| else await member?.roles.add(role); |
Member
There was a problem hiding this comment.
Ta linijka się wykona nawet jeśli nie ma role, tak ma być?
src/roles/roles.ts
Outdated
| if (!member) console.error(`Member with id ${memberId} doesn't exists!`); | ||
| if (!role) console.error(`Role for karma doesn't exists`); | ||
| else await member?.roles.add(role); | ||
| } catch (err) { |
Member
There was a problem hiding this comment.
Pozbyłbym się tego try catch stąd
src/roles/roles.ts
Outdated
| const startDate = offsetDateByWeeks(new Date(), 2); | ||
| const bestKarmaMembers = await getBestMembers(startDate); | ||
|
|
||
| await Promise.all(bestKarmaMembers.map(({ _id }) => giveRole(guild, role, _id))); |
Member
There was a problem hiding this comment.
Suggested change
| await Promise.all(bestKarmaMembers.map(({ _id }) => giveRole(guild, role, _id))); | |
| return Promise.all(bestKarmaMembers.map(({ _id }) => giveRole(guild, role, _id))); |
src/roles/roles.ts
Outdated
| const reassignRoles = async () => { | ||
| const client = new Discord.Client(); | ||
| await client.login(getConfig('DISCORD_BOT_TOKEN')); | ||
| const guild = client.guilds.cache.get(TYPE_OF_WEB_GUILD_ID); |
Member
There was a problem hiding this comment.
A jeśli nie ma gildii w cache?
src/roles/roles.ts
Outdated
| const karmaRole = await getKarmaRole(guild); | ||
|
|
||
| await removeMembersRoles(karmaRole); | ||
| await assignMembersRoles(guild, karmaRole); |
Member
There was a problem hiding this comment.
Pozbyłbym się wszystkich try…catch z pozostałych funkcji i dał try…catch tylko tutaj na obie te funkcje :)
typeofweb
reviewed
Jan 8, 2022
src/roles/roles.ts
Outdated
| }; | ||
|
|
||
| const fetchKarmaRole = async (guild: Discord.Guild) => { | ||
| return (await guild.roles.fetch()).cache.find((role) => role.name === ROLE_NAME); |
Member
There was a problem hiding this comment.
Suggested change
| return (await guild.roles.fetch()).cache.find((role) => role.name === ROLE_NAME); | |
| const roles = await guild.roles.fetch(); | |
| return roles.cache.find((role) => role.name === ROLE_NAME); |
src/roles/roles.ts
Outdated
Comment on lines
32
to
33
| if (role) return role; | ||
| else return createKarmaRole(guild); |
Member
There was a problem hiding this comment.
Suggested change
| if (role) return role; | |
| else return createKarmaRole(guild); | |
| if (role) { | |
| return role; | |
| } else { | |
| return createKarmaRole(guild); | |
| } |
src/roles/roles.ts
Outdated
| await client.login(getConfig('DISCORD_BOT_TOKEN')); | ||
| const guild = client.guilds.cache.get(TYPE_OF_WEB_GUILD_ID); | ||
|
|
||
| if (!guild) return console.error(`Guild with id ${TYPE_OF_WEB_GUILD_ID} doesn't exists!`); |
Member
There was a problem hiding this comment.
Suggested change
| if (!guild) return console.error(`Guild with id ${TYPE_OF_WEB_GUILD_ID} doesn't exists!`); | |
| if (!guild) { | |
| return console.error(`Guild with id ${TYPE_OF_WEB_GUILD_ID} doesn't exists!`); | |
| } |
src/roles/roles.ts
Outdated
|
|
||
| const karmaRole = await getKarmaRole(guild); | ||
|
|
||
| if (!karmaRole) return console.error(`Karma role doesn't exists!`); |
Member
There was a problem hiding this comment.
Suggested change
| if (!karmaRole) return console.error(`Karma role doesn't exists!`); | |
| if (!karmaRole) { | |
| return console.error(`Karma role doesn't exists!`); | |
| } |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function gives roles for top members of the last two weeks.