Query with params throwing ERR_INVALID_ARG_TYPE

[srwilliamg]

Issue Description

When i run a query with params
example: Test.find({ where: { id } });
Im gettting the following error:
originalError: QueryFailedError: Error: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received type number (0)
code: ERR_INVALID_ARG_TYPE
When i try to use a QueryBuilder passing the argument directly
Test.createQueryBuilder('test').where('id = ${id}').getOne();
this works perfectly

Expected Behavior

return the query result

Actual Behavior

originalError: QueryFailedError: Error: The "string" argument must be of type string or an instance of Buffer or ArrayBuffer. Received type number (0)
code: ERR_INVALID_ARG_TYPE

`Test.find({ where: { id } });`

query failed: SELECT "test"."id" AS "test_id", "test"."test_name" AS "test_test_name", "test"."test_lastname" AS "test_test_lastname" FROM "dbo"."test" "test" WHERE id = @0 -- PARAMETERS: [1]

My Environment

Dependency	Version
Operating System	ubuntu
Node.js version	v14.17.2
Typescript version	typescript@4.0.5
TypeORM version	typeorm@0.2.29

Additional Context

Relevant Database Driver(s)

DB Type	Reproducible
aurora-data-api	no
aurora-data-api-pg	no
better-sqlite3	no
cockroachdb	no
cordova	no
expo	no
mongodb	no
mysql	no
nativescript	no
oracle	no
postgres	no
react-native	no
sap	no
sqlite	no
sqlite-abstract	no
sqljs	no
sqlserver	yes

Are you willing to resolve this issue by submitting a Pull Request?

• ✖️ Yes, I have the time, and I know how to start.
• ✖️ Yes, I have the time, but I don't know how to start. I would need guidance.
• ✖️ No, I don’t have the time, but I can support (using donations) development.
• ✅ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.

[imnotjames]

What's the query?

What's the parameters?

There's very, very little to go off of, here.

[imnotjames]

When opening an issue, people will be better able to provide help if you provide code that they can easily understand and use to reproduce the problem. This boils down to ensuring your code that reproduces the problem follows the following guidelines:

• Minimal – Use as little code as possible that still produces the same problem
• Complete – Provide all parts someone else needs to reproduce your problem in the question itself
• Reproducible – Test the code you're about to provide to make sure it reproduces the problem

Minimal

The more code there is to go through, the less likely people can find your problem. Streamline your example in one of two ways:

1. Restart from scratch. Create a new program, adding in only what is needed to see the problem. Use simple, descriptive names for functions and variables – don’t copy the names you’re using in your existing code.
2. Divide and conquer. If you’re not sure what the source of the problem is, start removing code a bit at a time until the problem disappears – then add the last part back.

Don't sacrifice clarity for brevity when creating a minimal example. Use consistent naming and indentation, and include code comments if needed. Use your code editor’s shortcut for formatting code.

Don't include any passwords or credentials that must be kept secret.

Complete

Make sure all information necessary to reproduce the problem is included in the issue itself.

If the problem requires some code as well as some XML-based configuration, include code for both. The problem might not be in the code that you think it is in.

Use individual code blocks for each file or snippet you include. Provide a description for the purpose of each block.

DO NOT use images of code. Copy the actual text from your code editor, paste it into the issus, then format it as code. This helps others more easily read and test your code.

Reproducible

To help you solve your problem, others will need to verify that it exists.

Describe the problem. "It doesn't work" isn't descriptive enough to help people understand your problem. Instead, tell other readers what the expected behavior should be. Tell other readers what the exact wording of the error message is, and which line of code is producing it. Use a brief but descriptive summary of your problem as the title of your question.

Eliminate any issues that aren't relevant to the problem. If your question isn’t about a compiler error, ensure that there are no compile-time errors.

Double-check that your example reproduces the problem! If you inadvertently fixed the problem while composing the example but didn't test it again, you'd want to know that before asking someone else to help.

[srwilliamg]

What's the query?

What's the parameters?

There's very, very little to go off of, here.

Sorry i just finished to update the description

[imnotjames]

What's the definition of the entity Test?

[srwilliamg]

What's the definition of the entity Test?

@Entity('test', { schema: 'dbo' })
export class Test extends BaseEntity {
  @PrimaryColumn({
    type: 'int',
    name: 'id',
    nullable: false,
    comment:
      'This column represents the id of the entity. It composes the primary key of the table',
  })
  id: number;

  @Column('nvarchar', {
    name: 'test_name',
    nullable: false,
    length: 36,
  })
  name: string;

  @Column('nvarchar', {
    name: 'test_lastname',
    nullable: false,
    length: 36,
  })
  lastname: string;
}

[imnotjames]

I can't replicate - here's the test I created: https://gist.github.com/imnotjames/ae87930e4044a9f4d41d1f123bdba86b

Results:

  github issues > #8070 Query with params throwing ERR_INVALID_ARG_TYPE
    ✓ should correctly attempt to find by ID


  1 passing (366ms)

Can you create a test case that fails?

[srwilliamg]

I can't replicate - here's the test I created: https://gist.github.com/imnotjames/ae87930e4044a9f4d41d1f123bdba86b

Results:

  github issues > #8070 Query with params throwing ERR_INVALID_ARG_TYPE
    ✓ should correctly attempt to find by ID


  1 passing (366ms)

Can you create a test case that fails?

I find the issue, the npm package mssql : "^7.2.0"
I changed to mssql: "^6.3.2" and it works well

[imnotjames]

I have installed mssql 7.2.0 & re-ran the tests.

$ npm explain tedious

tedious@11.4.0 dev
node_modules/tedious
  tedious@"^11.0.7" from mssql@7.2.0
  node_modules/mssql
    dev mssql@"^7.2.0" from the root project

I had to set trustServerCertificate to true.

However, the tests still passed.

[vinu-vrize]

@srwilliamg Were you able to resolve the issue, is it by downgrading the mssql to "^6.3.2".

Could you please provide the respective versions of the below modules if you have used:

• typeorm
• mssql
• tedious

[github-actions]

TypeORM has returned to active development after recently transitioning to new leadership (see related announcement).

As part of the new team's efforts to prioritise work on the project moving forward, it is necessary to clean up the backlog of stale issues.

🧹 This issue is being automatically closed because it has had no activity in the last 6 months.
If you believe this issue is still relevant, feel free to comment below and the maintainers may reopen it. Thank you for your contribution.