This repository was archived by the owner on Jul 16, 2021. It is now read-only.
Extend EventEmitter rather than implement it #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See DefinitelyTyped#10977 Since Node's EventEmitter is a class with implementation, the previous version of this is fragile when the base class adds new members, an implements definition needs changes. By using `extends` rather than `implments`, inheritance of new methods is automatic.
|
I think this is good. cc/@blakeembrey to confirm. |
|
LGTM @unional |
|
This appears to be broken. See my comment on DefinitelyTyped #10977. Thanks! |
|
@unional What if it does |
|
Seems like it. PR filed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DefinitelyTyped#10977
Since Node's EventEmitter is a class with implementation, the previous version of this is fragile when the base class adds new members, an implements definition needs changes. By using
extendsrather thanimplments, inheritance of new methods is automatic.