Skip to content

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented May 14, 2019

Thought I propose something uncontroversial as my first direct contribution 😉

This is mostly about the codeblocks. It will come in handy once eslint-plugin-markdown can handle tsx? codeblocks and then we'll be able to typecheck the codeblocks (did hack something together locally which already revealed some issues; will propose fixes separately).

Edit: It will not catch syntax error: f0b3cfd, see prettier/prettier#6010

No strong opinions about how we maintain the formatting from me. Maybe discuss this in a separate issue? PRs are rare enough that manual verification is probably sufficient.

Edit2:
Used prettier configuration:

"prettier": {
  "singleQuote": true
}

Copy link
Collaborator

@ferdaber ferdaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always like Prettier

@eps1lon eps1lon requested a review from swyxio May 15, 2019 09:57
@eps1lon
Copy link
Member Author

eps1lon commented May 15, 2019

@sw-yx Is that ok for you? I think we should all be on the same page for this. Especially concerning the prettier configuration.

@swyxio
Copy link
Collaborator

swyxio commented May 16, 2019

yes absolutely. sorry ive just been busy past couple days 😅

@swyxio swyxio merged commit 02c7efe into typescript-cheatsheets:master May 16, 2019
@swyxio
Copy link
Collaborator

swyxio commented May 16, 2019

i have also added https://github.com/kevgo/prettifier as a github app, i have never used it before but hopefully it works

@eps1lon eps1lon deleted the chore/format branch May 16, 2019 16:46
@eps1lon
Copy link
Member Author

eps1lon commented May 16, 2019

i have also added kevgo/prettifier as a github app, i have never used it before but hopefully it works

Didn't know that one. That's IMO way better than some CI yelling at you.

I [tried something with Github actions but it didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants