Skip to content

rxjs-no-async-subscribe #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2020
Merged

rxjs-no-async-subscribe #775

merged 3 commits into from
Nov 2, 2020

Conversation

@kbrilla
Copy link
Contributor

@kbrilla kbrilla commented Oct 31, 2020 •
edited
Loading

PR Checklist

Overview

first of many converters to convert rules from cartant/rxjs-tslint-rules to cartant/eslint-plugin-rxjs

@kbrilla kbrilla changed the title Adding the rule, mapping it and writing the tests rxjs-no-async-subscribe Oct 31, 2020
KingDarBoja
KingDarBoja approved these changes Oct 31, 2020
View reviewed changes
Copy link
Collaborator

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a rolling stone 🗿

@KingDarBoja KingDarBoja merged commit bc4d678 into typescript-eslint:main Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rxjs-no-async-subscribe

2 participants

@kbrilla @KingDarBoja