fix(scope-manager): exclude Program from DefinitionBase node types

[dbarabashh]

Fix #11334

PR Checklist

• Addresses an existing open issue: fixes Bug: DefinitionBase shouldn't allow its Node type to be TSESTree.Program #11334
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This PR improves type safety in the scope-manager package by preventing TSESTree.Program nodes from being used as definition nodes.

[typescript-eslint]

Thanks for the PR, @dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	382a149
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68b0b4fce94a83000803763e
😎 Deploy Preview	https://deploy-preview-11469--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 77 (🔴 down 20 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 382a149

Command	Status	Duration	Result
nx test eslint-plugin --coverage=false	✅ Succeeded	5m 16s	View ↗
nx run-many -t lint	✅ Succeeded	3m 13s	View ↗
nx run-many -t typecheck	✅ Succeeded	2m 22s	View ↗
nx test typescript-estree --coverage=false	✅ Succeeded	21s	View ↗
nx test eslint-plugin-internal --coverage=false	✅ Succeeded	9s	View ↗
nx run integration-tests:test	✅ Succeeded	6s	View ↗
nx run types:build	✅ Succeeded	5s	View ↗
nx run generate-configs	✅ Succeeded	9s	View ↗
Additional runs (27)	✅ Succeeded	...	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-08-28 20:11:12 UTC

[dbarabashh]

I am not sure that the linter failed now exactly because of my changes, because locally this command was successful

[JoshuaKGoldberg]

Try a yarn build first, then a yarn lint? It looks like the types are better informed because of this change (nice!), so lint rules are pointing out previously missed unnecessary ?.s and the like.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (31a7336) to head (382a149).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11469      +/-   ##
==========================================
- Coverage   90.87%   90.87%   -0.01%     
==========================================
  Files         505      505              
  Lines       51146    51143       -3     
  Branches     8424     8424              
==========================================
- Hits        46480    46477       -3     
  Misses       4652     4652              
  Partials       14       14              

Flag	Coverage Δ
unittest	90.87% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...t-plugin/src/rules/no-confusing-void-expression.ts	100.00% <100.00%> (ø)
...s/eslint-plugin/src/util/collectUnusedVariables.ts	96.19% <100.00%> (ø)
...ges/scope-manager/src/definition/DefinitionBase.ts	100.00% <ø> (ø)
...src/definition/ImplicitGlobalVariableDefinition.ts	100.00% <ø> (ø)
packages/scope-manager/src/referencer/Reference.ts	93.44% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dbarabashh]

@JoshuaKGoldberg thank you, done

[kirkwaiblinger]

@dbarabashh Would you mind also auditing for uses of nullThrows that can be removed? For example,

typescript-eslint/packages/eslint-plugin/src/rules/no-confusing-void-expression.ts

Line 368 in 63ab002

const block = nullThrows(node.parent, NullThrowsReasons.MissingParent);

[JoshuaKGoldberg]

+1 to what Kirk said. I also think the new type is good enough that it should be moved to @typescript-eslint/types altogether. Thanks for starting this! 🙌

[JoshuaKGoldberg]

🤤 look at all those removed ?~s and nullThrows()`s! Absolutely lovely. Thanks!

[kirkwaiblinger]

🎉🎉