-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports #11359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports #11359
Conversation
Thanks for the PR, @mainframev! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit a09f911
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11359 +/- ##
=======================================
Coverage 90.91% 90.92%
=======================================
Files 505 505
Lines 51153 51191 +38
Branches 8426 8436 +10
=======================================
+ Hits 46506 46544 +38
Misses 4634 4634
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
51cabaf
to
dd8869b
Compare
d81f2e1
to
a1d06d3
Compare
const symbol = services.getSymbolAtLocation(node.exported); | ||
|
||
if (searchForDeprecationInAliasesChain(symbol, false) == null) { | ||
checkIdentifier(node.exported as TSESTree.Identifier); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
safer to use conditional statements than type casting.
if (
searchForDeprecationInAliasesChain(symbol, false) == null &&
node.exported.type === AST_NODE_TYPES.Identifier
) {
checkIdentifier(node.exported);
}
or
function checkIdentifier(node: IdentifierLike | TSESTree.StringLiteral): void
It seems like a rare case, this is example of literal.
export { foo as 'bar' } from 'baz';
export { 'foo' } from 'bar';
(Maybe, there will be no problem in operation. Could you test these cases?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nayounsang hi, thanks! updated 👍🏻
export { 'deprecatedFunction' } from './deprecated'; | ||
`, | ||
` | ||
export { deprecatedFunction as 'bar' } from './deprecated'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think this is far from a real-world use case and can be safely ignored. But, this tc is dupe: export { deprecatedFunction as 'bur' } from './deprecated';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nayounsang removed, thanks!
Also, I’ve tweaked it again a bit. While tests and lint were passing locally, on our side CI lint step was getting stuck in an infinite loop. After updating the searchForDeprecationInAliasesChain
to handle alias chains, the hang no longer occurs
4ebcabc
to
24f6648
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 🚀
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 | | npm | @typescript-eslint/parser | 8.42.0 | 8.43.0 | ## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08) ##### 🚀 Features - **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563)) ##### 🩹 Fixes - **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432)) - **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359)) - **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430)) - **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457)) - **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517)) - **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469)) - **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489)) - **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526)) ##### ❤️ Thank You - Dima [@dbarabashh](https://github.com/dbarabashh) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - tao - Victor Genaev [@mainframev](https://github.com/mainframev) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) - 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429) - 송재욱 You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
PR Checklist
Overview
isInsideExportOrImport
guard function and renamed it toisInsideImport
to skip only imports.