Skip to content

Conversation

mainframev
Copy link
Contributor

@mainframev mainframev commented Jun 30, 2025

PR Checklist

Overview

  • Removed skipping of export statements from isInsideExportOrImport guard function and renamed it to isInsideImport to skip only imports.
  • Updated the test file with export / reexports cases

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mainframev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 30, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a09f911
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68bee3c8886de40008ecc397
😎 Deploy Preview https://deploy-preview-11359--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jun 30, 2025

View your CI Pipeline Execution ↗ for commit a09f911

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 9s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 2s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 15s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-08 14:23:39 UTC

@mainframev mainframev changed the title fix(eslint-plugin)[no-deprecated]: should report deprecated exports and reexports fix(eslint-plugin):[no-deprecated] should report deprecated exports and reexports Jun 30, 2025
@mainframev mainframev changed the title fix(eslint-plugin):[no-deprecated] should report deprecated exports and reexports fix(eslint-plugin): [no-deprecated] should report deprecated exports and reexports Jun 30, 2025
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (f77a31d) to head (a09f911).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11359   +/-   ##
=======================================
  Coverage   90.91%   90.92%           
=======================================
  Files         505      505           
  Lines       51153    51191   +38     
  Branches     8426     8436   +10     
=======================================
+ Hits        46506    46544   +38     
  Misses       4634     4634           
  Partials       13       13           
Flag Coverage Δ
unittest 90.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts 97.15% <100.00%> (+0.16%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mainframev mainframev force-pushed the fix/no-deprecated-rule-support-exports-reexports branch from 51cabaf to dd8869b Compare June 30, 2025 18:47
@mainframev mainframev marked this pull request as ready for review June 30, 2025 20:25
@mainframev mainframev marked this pull request as draft July 2, 2025 10:29
@mainframev mainframev force-pushed the fix/no-deprecated-rule-support-exports-reexports branch from d81f2e1 to a1d06d3 Compare July 2, 2025 11:32
@mainframev mainframev marked this pull request as ready for review July 2, 2025 11:53
const symbol = services.getSymbolAtLocation(node.exported);

if (searchForDeprecationInAliasesChain(symbol, false) == null) {
checkIdentifier(node.exported as TSESTree.Identifier);
Copy link
Contributor

@nayounsang nayounsang Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safer to use conditional statements than type casting.

        if (
          searchForDeprecationInAliasesChain(symbol, false) == null &&
          node.exported.type === AST_NODE_TYPES.Identifier
        ) {
          checkIdentifier(node.exported);
        }

or

function checkIdentifier(node: IdentifierLike | TSESTree.StringLiteral): void

It seems like a rare case, this is example of literal.

export { foo as 'bar' } from 'baz';
export { 'foo' } from 'bar';

(Maybe, there will be no problem in operation. Could you test these cases?)

Copy link
Contributor Author

@mainframev mainframev Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayounsang hi, thanks! updated 👍🏻

@mainframev mainframev requested a review from nayounsang July 8, 2025 08:36
export { 'deprecatedFunction' } from './deprecated';
`,
`
export { deprecatedFunction as 'bar' } from './deprecated';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this is far from a real-world use case and can be safely ignored. But, this tc is dupe: export { deprecatedFunction as 'bur' } from './deprecated';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayounsang removed, thanks!

Also, I’ve tweaked it again a bit. While tests and lint were passing locally, on our side CI lint step was getting stuck in an infinite loop. After updating the searchForDeprecationInAliasesChain to handle alias chains, the hang no longer occurs

@mainframev mainframev force-pushed the fix/no-deprecated-rule-support-exports-reexports branch from 4ebcabc to 24f6648 Compare July 21, 2025 10:35
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 3, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 3, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit d8ca5ef into typescript-eslint:main Sep 8, 2025
62 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 10, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.42.0 | 8.43.0 |
| npm        | @typescript-eslint/parser        | 8.42.0 | 8.43.0 |


## [v8.43.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)

##### 🚀 Features

- **typescript-estree:** disallow empty type parameter/argument lists ([#11563](typescript-eslint/typescript-eslint#11563))

##### 🩹 Fixes

- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#11432](typescript-eslint/typescript-eslint#11432))
- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#11359](typescript-eslint/typescript-eslint#11359))
- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#11423](typescript-eslint/typescript-eslint#11423), [#11430](typescript-eslint/typescript-eslint#11430))
- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#11457](typescript-eslint/typescript-eslint#11457))
- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#11517](typescript-eslint/typescript-eslint#11517))
- **scope-manager:** exclude Program from DefinitionBase node types ([#11469](typescript-eslint/typescript-eslint#11469))
- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#11489](typescript-eslint/typescript-eslint#11489))
- **type-utils:** add union type support to TypeOrValueSpecifier ([#11526](typescript-eslint/typescript-eslint#11526))

##### ❤️ Thank You

- Dima [@dbarabashh](https://github.com/dbarabashh)
- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
- mdm317
- tao
- Victor Genaev [@mainframev](https://github.com/mainframev)
- Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)
- 민감자(Minji Kim) [@mouse0429](https://github.com/mouse0429)
- 송재욱

You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] doesn't work on export/re-export statements

3 participants