Skip to content

Conversation

peanutenthusiast
Copy link
Contributor

@peanutenthusiast peanutenthusiast commented Sep 24, 2025

PR Checklist

Overview

Add @deprecated comments to TestCaseError#type in rule-tester package, LintMessage#nodeType in ts-eslint package

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @peanutenthusiast!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 22bf021
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68d3a483d569720008ab6adb
😎 Deploy Preview https://deploy-preview-11628--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Sep 24, 2025

View your CI Pipeline Execution ↗ for commit 22bf021

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 5s View ↗
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 3s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-24 08:09:36 UTC

@peanutenthusiast peanutenthusiast marked this pull request as ready for review September 24, 2025 15:31
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 29, 2025
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore(rule-tester): deprecate TestCaseError#type and LintMessage#nodeType fix(rule-tester): deprecate TestCaseError#type and LintMessage#nodeType Oct 1, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit e2d549e into typescript-eslint:main Oct 1, 2025
69 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 8, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 |
| npm        | @typescript-eslint/parser        | 8.45.0 | 8.46.0 |


## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)

##### 🚀 Features

- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659))
- **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633))

##### 🩹 Fixes

- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660))
- **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657))
- **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674))
- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603))
- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634))
- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628))
- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487))

##### ❤️ Thank You

- fisker Cheung [@fisker](https://github.com/fisker)
- Josh Goldberg ✨
- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
- Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)
- Richard Torres [@richardtorres314](https://github.com/richardtorres314)
- Victor Genaev [@mainframev](https://github.com/mainframev)

You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 8, 2025
| datasource | package                          | from   | to     |
| ---------- | -------------------------------- | ------ | ------ |
| npm        | @typescript-eslint/eslint-plugin | 8.45.0 | 8.46.0 |
| npm        | @typescript-eslint/parser        | 8.45.0 | 8.46.0 |


## [v8.46.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)

##### 🚀 Features

- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#11659](typescript-eslint/typescript-eslint#11659))
- **rule-schema-to-typescript-types:** clean up and make public ([#11633](typescript-eslint/typescript-eslint#11633))

##### 🩹 Fixes

- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#11660](typescript-eslint/typescript-eslint#11660))
- **typescript-estree:** forbid abstract method and accessor to have implementation ([#11657](typescript-eslint/typescript-eslint#11657))
- **eslint-plugin:** removed error type previously deprecated ([#11674](typescript-eslint/typescript-eslint#11674))
- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#11603](typescript-eslint/typescript-eslint#11603))
- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#11634](typescript-eslint/typescript-eslint#11634))
- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#11628](typescript-eslint/typescript-eslint#11628))
- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#11487](typescript-eslint/typescript-eslint#11487))

##### ❤️ Thank You

- fisker Cheung [@fisker](https://github.com/fisker)
- Josh Goldberg ✨
- Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)
- Mark de Dios [@peanutenthusiast](https://github.com/peanutenthusiast)
- Richard Torres [@richardtorres314](https://github.com/richardtorres314)
- Victor Genaev [@mainframev](https://github.com/mainframev)

You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement(rule-tester): deprecate TestCaseError#type and LintMessage#nodeType
2 participants