Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Extract IsSpecificTokenFunction & IsNotSpecificTokenFunction generics to simplify IsPunctuatorTokenWithValueFunction & IsNotPunctuatorTokenWithValueFunction even more and to simplify the types of isCommentToken & isNotCommentToken

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #3569 (8fb5dbf) into master (84fff35) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3569      +/-   ##
==========================================
- Coverage   92.64%   92.52%   -0.12%     
==========================================
  Files         326      187     -139     
  Lines       11253     8393    -2860     
  Branches     3171     2580     -591     
==========================================
- Hits        10425     7766    -2659     
+ Misses        368      261     -107     
+ Partials      460      366      -94     
Flag Coverage Δ
unittest 92.52% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tal-utils/src/ast-utils/eslint-utils/predicates.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2015.promise.ts
...-manager/src/definition/ImportBindingDefinition.ts
...ckages/scope-manager/src/lib/webworker.iterable.ts
packages/scope-manager/src/lib/es2015.core.ts
...ges/scope-manager/src/definition/DefinitionBase.ts
packages/scope-manager/src/lib/es2020.promise.ts
...ages/scope-manager/src/lib/es2016.array.include.ts
...ges/typescript-estree/src/create-program/shared.ts
.../scope-manager/src/variable/ESLintScopeVariable.ts
... and 130 more

@bradzacher bradzacher added the refactor PRs that refactor code only label Jul 31, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit b362620 into typescript-eslint:master Jul 31, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-14 branch July 31, 2021 23:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor PRs that refactor code only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants