Skip to content

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented May 12, 2019

The end{Line,Column} are nice to verify ranges of error messages.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/2194a1ac8b3e83a882b07257a8dfdc94b5fe2b72/types/eslint/index.d.ts#L565-L574

endColumn?: number;
endLine?: number;

Couldn't find anywhere where its omission was discussed


Thanks so much for publishing these! Will be converting eslint-plugin-jest to use them.

@bradzacher
Copy link
Member

I never bothered with them as 99% of the time when we report an error, we pass in the node.
Which means that you're not overly concerned with the end line, just a line+col(+node name) combo.

Happy for them to be added though!

@bradzacher bradzacher merged commit d9e5f15 into typescript-eslint:master May 12, 2019
@SimenB SimenB deleted the patch-1 branch May 13, 2019 05:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants