Skip to content

Intergrating with Build Tools 전체 검토 및 번역 (ref #54) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2020
Merged

Intergrating with Build Tools 전체 검토 및 번역 (ref #54) #68

merged 3 commits into from
May 17, 2020

Conversation

@dvlprsh
Copy link
Member

@dvlprsh dvlprsh commented May 13, 2020

리뷰 부탁드립니다 :)

@bumkeyy bumkeyy requested review from bumkeyy, guyeol and yeonjuan May 14, 2020 00:01
@bumkeyy
Copy link
Member

bumkeyy commented May 14, 2020

@yeonjuan @guyeol @dvlprsh

해당 문서는 라인 수와 린트 룰이 충돌 하는데 어떻게 정할까요?
전 이 문서의 라인 수는 예외로 두고 린트를 맞추는 게 낫다고 생각합니다.
기본적인 린트 룰이 너무 안맞는 것 같아요.

의견 주시면 감사하겠습니다 😄

@dvlprsh
Copy link
Member Author

dvlprsh commented May 14, 2020 •
edited
Loading

@bumkeyy
저도 린트 룰을 따르는게 나은 거 같아요!
@yeonjuan @guyeol
두 분도 의견 주시면 수정 하겠습니다~

@bumkeyy bumkeyy added the 🚀 번역중 번역을 진행하고 있어요 label May 15, 2020
@yeonjuan
Copy link
Contributor

yeonjuan commented May 15, 2020

저도 린트 룰을 따르는게 나은 거 같아요!
@dvlprsh 넵 저도 동의합니다

@dvlprsh
Copy link
Member Author

dvlprsh commented May 17, 2020

@bumkeyy
린트 수정 했습니다!

bumkeyy
bumkeyy approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@bumkeyy bumkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당 👍

@bumkeyy bumkeyy merged commit 2e6ec49 into master May 17, 2020
@bumkeyy
Copy link
Member

bumkeyy commented May 17, 2020

closed #54

@bumkeyy bumkeyy deleted the issue54-dvlprsh branch May 17, 2020 04:45
@bumkeyy bumkeyy linked an issue May 17, 2020 that may be closed by this pull request
Project Configuration / Intergrating with Build Tools 번역 #54
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bumkeyy bumkeyy bumkeyy approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

@guyeol guyeol Awaiting requested review from guyeol

Assignees

No one assigned

Labels

🚀 번역중 번역을 진행하고 있어요

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Project Configuration / Intergrating with Build Tools 번역

4 participants

@dvlprsh @bumkeyy @yeonjuan