This repository was archived by the owner on Sep 17, 2023. It is now read-only.
chore: clarify that the internal dependency resolver is exclusive#216
Merged
EricCrosson merged 1 commit intoDec 7, 2022
Merged
Conversation
EricCrosson
approved these changes
Dec 7, 2022
EricCrosson
left a comment
EricCrosson
left a comment
Contributor
There was a problem hiding this comment.
Thanks @bitgopatmcl !
|
🎉 This PR is included in version 4.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
@bitgopatmcl This is actually a breaking change, since we're renaming something in the public API. I'll force a release |
EricCrosson
added a commit
that referenced
this pull request
Dec 8, 2022
This forces a release of #216 under a new major version, since that PR renames an exported function to more clearly express its behavior. BREAKING CHANGE: rename `transitive_internal_dependency_package_names` to `transitive_internal_dependency_package_names_exclusive`.
github-actions Bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
# [5.0.0](v4.3.5...v5.0.0) (2022-12-08) * fix!: rename function with _exclusive suffix ([aeb54fe](aeb54fe)), closes [#216](#216) ### BREAKING CHANGES * rename `transitive_internal_dependency_package_names` to `transitive_internal_dependency_package_names_exclusive`.
Contributor
|
Whoops, this one snuck out as 4.3.5 because of #217! Since the upgrade path is near-trivial, I don't think it's urgent to revert this diff in the 4.x branch. I'll leave this as a note to any future traveler as a compromise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.