Skip to content

Conversation

@haydenhoang
Copy link
Contributor

@haydenhoang haydenhoang commented Sep 7, 2024

Change Summary

URL encode user-inputted Ids to prevent injection & allow usage of special characters.

Features

  • Added an utility class URLEncoding inside typesense/api/utils.
  • Log test results when running gradle build
  • Run tests in Github actions with matrix strategy using JDK 8, 11, 17
  • Add Aliases test testUpsertWithURLEncodedName

Fixes

Build errors:

  • Can not create openapi.yml file because parent directories do not exist.
  • Task ':sourcesJar' uses output of task ':generateSwaggerCodeTypesense' without declaring it as a dependency.
  • Javadoc

Excluded the script to download books.jsonl from github actions config file since it's unused.

PR Checklist

@kishorenc kishorenc merged commit 129935f into typesense:master Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants