Conversation
| my $archive = catfile("msgpack-1.4.2", "src", ".libs", "libmsgpackc.a"); | ||
| if (!$self->up_to_date($archive, $spec->{lib_file})) { | ||
| $self->_build_msgpack or die; | ||
| push @{$self->{properties}{objects}}, $archive; # XXX |
There was a problem hiding this comment.
I'm not sure this is good, but it works :)
| sub _build_msgpack { | ||
| my $self = shift; | ||
|
|
||
| $self->_set_mtime; |
There was a problem hiding this comment.
We should restore original mtime in msgpack-1.4.2.tar.gz; otherwise end-users might be asked for having automake tools.
|
@typester I guess syohex is busy. I would appreciate it if you review this PR too. |
|
ping? |
|
@typester Thank you for merging this! FYI: Minilla will take care of almost all releasing stuff (e.g., bump version, rewrite Changes file). |
|
Yeah, I know It is not impossible at all but needs complicated docker command-line (or to create my own image) that I can't remember :'( |
|
Fair enough! |
3 participants
Use of Module::Install for new distributions is discouraged by its maintainers.
https://metacpan.org/pod/Module::Install#WARNING
So why don't you migrate to Minilla?
I hope this change makes Data-MessagePack-Stream more maintainable.
Note:
https://travis-ci.com/skaji/Data-MessagePack-Stream/builds/77454121
I will create another PR that fixes this.