Skip to content

Commit 7cbeb39

Browse files
committed
fix(dialog): add default position for dialog close button
1 parent 2db8664 commit 7cbeb39

File tree

3 files changed

+23
-13
lines changed

3 files changed

+23
-13
lines changed

docs/examples/dialog/Overview.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<script setup lang="ts">
22
import {
33
Button,
4+
CloseButton,
45
DialogRoot,
56
DialogTrigger,
67
DialogPopup,
@@ -33,6 +34,7 @@ import {
3334
<Button variant="classic" color="gray" :as="DialogClose">Cancel</Button>
3435
<Button>Save</Button>
3536
</div>
37+
<CloseButton :as="DialogClose" />
3638
</DialogPopup>
3739
</DialogRoot>
3840
</template>

src/components/dialog/style.css

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,16 @@
4545
max-height: var(--dialog-popup-max-height);
4646
padding: var(--dialog-popup-padding);
4747
}
48-
}
4948

49+
:where(.ui-DialogPopup) .ui-CloseButton {
50+
position: absolute;
51+
top: calc(var(--dialog-popup-padding) / 2);
52+
right: calc(var(--dialog-popup-padding) / 2);
53+
}
54+
}
5055

5156
.ui-DialogPopup:where(.r-size-1) {
52-
--dialog-popup-padding: var(--space-3);
57+
--dialog-popup-padding: var(--space-4);
5358
--dialog-popup-radius: var(--radius-4);
5459
--dialog-popup-max-width: 450px;
5560
--dialog-popup-max-height: calc(100vh - 100px);
@@ -67,7 +72,7 @@
6772
--dialog-popup-max-height: calc(100vh - 100px);
6873
}
6974
.ui-DialogPopup:where(.r-size-4) {
70-
--dialog-popup-padding: var(--space-6);
75+
--dialog-popup-padding: var(--space-5);
7176
--dialog-popup-radius: var(--radius-5);
7277
--dialog-popup-max-width: 1200px;
7378
--dialog-popup-max-height: calc(100vh - 100px);
@@ -86,11 +91,12 @@
8691
padding-left: var(--space-4);
8792
padding-right: var(--space-4);
8893
}
89-
90-
.ui-DialogPopup {
91-
box-shadow: var(--shadow-6);
92-
border-bottom-left-radius: var(--dialog-popup-radius);
93-
border-bottom-right-radius: var(--dialog-popup-radius);
94+
@layer components {
95+
.ui-DialogPopup {
96+
box-shadow: var(--shadow-6);
97+
border-bottom-left-radius: var(--dialog-popup-radius);
98+
border-bottom-right-radius: var(--dialog-popup-radius);
99+
}
94100
}
95101
}
96102

src/components/radio/RadioGroupItem.vue

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,12 @@ const resetClass = buildPropsClass(props, ['size', 'variant', 'highContrast'])
3939
<style src="./style.css"></style>
4040

4141
<style>
42-
.ui-RadioGroupItem {
43-
display: inline-flex;
44-
align-items: center;
45-
gap: .5em;
46-
width: fit-content;
42+
@layer components {
43+
.ui-RadioGroupItem {
44+
display: inline-flex;
45+
align-items: center;
46+
gap: .5em;
47+
width: fit-content;
48+
}
4749
}
4850
</style>

0 commit comments

Comments
 (0)