[TASK] Remove further TSFE properties

The patch continues removing properties from
TypoScriptFrontendController.

We however keep one particular API:
TypoScript stdWrap .data (Data / getText) implemented in
ContentObjectRenderer->getData() knows "TSFE" and allows
accessing various properties, partially using a recursive
array key mechanism.

This area is part of "good old" TypoScript functionality,
breaking this could easily become a nightmare for integrators
when upgrading to TYPO3 v14: This stdWrap feature is rather
hard to understand, is often buried deep in TS setup, is not
trivial to test and hard to debug.

A compat layer has been established in v13 for other details
like ".data = TSFE : fe_user" already, the patch extends this
to especially keep support for ".data = TSFE : id" (and some
others) for the time being.

Resolves: #107527
Related: #105230
Related: #102621
Releases: main
Change-Id: I497474a1a8447b4416af11c48c34042adcd19464
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90777
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>

Author: lolli42

typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php

@@ -3868,7 +3868,6 @@ public function getData($string, $fieldArray = null)
                         $retVal = $this->getValueFromRecursiveData(GeneralUtility::trimExplode('|', $key), $this->getRequest());
                         break;
                     case 'tsfe':
-                        // @todo: This needs a bigger cleanup / deprecation when TypoScriptFrontendController continues to remove properties.
                         $valueParts = GeneralUtility::trimExplode('|', $key);
                         if (($valueParts[0] ?? '') === 'fe_user') {
                             $frontendUser = $this->getRequest()->getAttribute('frontend.user');
@@ -3883,8 +3882,20 @@ public function getData($string, $fieldArray = null)
                                     $this->getRequest()->getQueryParams(),
                                     GeneralUtility::makeInstance(Context::class)
                                 );
-                        } else {
-                            $retVal = $this->getValueFromRecursiveData($valueParts, $this->getTypoScriptFrontendController());
+                        } elseif (($valueParts[0] ?? '') === 'id') {
+                            $retVal = $this->getRequest()->getAttribute('frontend.page.information')->getId();
+                        } elseif (($valueParts[0] ?? '') === 'contentPid') {
+                            $retVal = $this->getRequest()->getAttribute('frontend.page.information')->getContentFromPid();
+                        } elseif (($valueParts[0] ?? '') === 'rootLine') {
+                            array_shift($valueParts);
+                            $retVal = $this->getValueFromRecursiveData($valueParts, $this->getRequest()->getAttribute('frontend.page.information')->getRootLine());
+                        } elseif (($valueParts[0] ?? '') === 'page') {
+                            array_shift($valueParts);
+                            $retVal = $this->getValueFromRecursiveData($valueParts, $this->getRequest()->getAttribute('frontend.page.information')->getPageRecord());
+                        } elseif (($valueParts[0] ?? '') === 'config' && ($valueParts[1] ?? '') === 'rootLine') {
+                            array_shift($valueParts);
+                            array_shift($valueParts);
+                            $retVal = $this->getValueFromRecursiveData($valueParts, $this->getRequest()->getAttribute('frontend.page.information')->getLocalRootLine());
                         }
                         break;
                     case 'getenv':

typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php

@@ -26,7 +26,6 @@
 use TYPO3\CMS\Core\Context\Context;
 use TYPO3\CMS\Core\Core\Environment;
 use TYPO3\CMS\Core\Database\ConnectionPool;
-use TYPO3\CMS\Core\Domain\Repository\PageRepository;
 use TYPO3\CMS\Core\Localization\Locale;
 use TYPO3\CMS\Core\Localization\Locales;
 use TYPO3\CMS\Core\Page\AssetCollector;
@@ -59,33 +58,6 @@
  */
 class TypoScriptFrontendController
 {
-    /**
-     * Use $request->getAttribute('frontend.page.information')->getId() instead.
-     */
-    public int $id;
-
-    /**
-     * Use $request->getAttribute('frontend.page.information')->getRootLine() instead.
-     *
-     * @var array<int, array<string, mixed>>
-     */
-    public array $rootLine = [];
-
-    /**
-     * Use $request->getAttribute('frontend.page.information')->getPageRecord() instead.
-     */
-    public ?array $page = [];
-
-    /**
-     * Available as @internal $request->getAttribute('frontend.page.information')->getContentFromPid().
-     */
-    public int $contentPid = 0;
-
-    /**
-     * Create own instance using GeneralUtility::makeInstance(PageRepository::class).
-     */
-    public PageRepository $sys_page;
-
     /**
      * A central data array consisting of various keys, initialized and
      * processed at various places in the class.
@@ -241,7 +213,6 @@ class TypoScriptFrontendController
      */
     public function __construct()
     {
-        $this->sys_page = GeneralUtility::makeInstance(PageRepository::class);
         $this->context = GeneralUtility::makeInstance(Context::class);
         $this->uniqueString = md5(microtime());
         $cacheManager = GeneralUtility::makeInstance(CacheManager::class);
@@ -316,7 +287,7 @@ protected function setPageCacheContent(
 
         // Respect the page cache when content of pid is shown
         if ($pageId !== $pageInformation->getContentFromPid()) {
-            $cacheDataCollector->addCacheTags(new CacheTag('pageId_' . $this->contentPid, $lifetime));
+            $cacheDataCollector->addCacheTags(new CacheTag('pageId_' . $pageInformation->getContentFromPid(), $lifetime));
         }
         if (!empty($pageRecord['cache_tags'])) {
             $tags = GeneralUtility::trimExplode(',', $pageRecord['cache_tags'], true);

typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php

@@ -106,11 +106,6 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
 
         $controller = GeneralUtility::makeInstance(TypoScriptFrontendController::class);
         $controller->initializePageRenderer($request);
-        $controller->id = $pageInformation->getId();
-        $controller->page = $pageInformation->getPageRecord();
-        $controller->contentPid = $pageInformation->getContentFromPid();
-        $controller->rootLine = $pageInformation->getRootLine();
-        $controller->config['rootLine'] = $pageInformation->getLocalRootLine();
         // Update SYS_LASTCHANGED at the very last, when page record was finally resolved.
         // Is also called when a translated page is in use, so the register reflects
         // the state of the translated page, not the page in the default language.