[TASK] Handle ext:styleguide phpstan baseline entries

This change handles 3 ext:styleguide related phpstan
baseline entries by:

* defining `readonly` related attribute values as string
* removing superfluous `is_array` checks

The `OnFieldChangeTrait` related baseline item for
ext:styleguide remains, as this should be fixed
globally in ext:backend.

Resolves: #108378
Releases: main, 13.4
Signed-off-by: Torben Hansen <derhansen@gmail.com>
Change-Id: I40f89f47d5990432b16a44aad4a5547da96be01c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91985
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>

Author: derhansen

Build/phpstan/phpstan-baseline.neon

@@ -4284,24 +4284,6 @@ parameters:
 			count: 1
 			path: ../../typo3/sysext/styleguide/Classes/Form/Element/User1Element.php
 
-		-
-			message: '#^Call to function is_array\(\) with list\<array\<string, mixed\>\> will always evaluate to true\.$#'
-			identifier: function.alreadyNarrowedType
-			count: 4
-			path: ../../typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordFinder.php
-
-		-
-			message: '#^Parameter \#1 \$arr of static method TYPO3\\CMS\\Core\\Utility\\GeneralUtility\:\:implodeAttributes\(\) expects array\<string, int\|string\>, array\<string, string\|true\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: ../../typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php
-
-		-
-			message: '#^Parameter \#1 \$arr of static method TYPO3\\CMS\\Core\\Utility\\GeneralUtility\:\:implodeAttributes\(\) expects array\<string, int\|string\>, array\<string, string\|true\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: ../../typo3/sysext/styleguide/Classes/ViewHelpers/ExampleViewHelper.php
-
 		-
 			message: '#^Instanceof between TYPO3\\CMS\\Core\\Site\\Entity\\Site and TYPO3\\CMS\\Core\\Site\\Entity\\Site will always evaluate to true\.$#'
 			identifier: instanceof.alwaysTrue

typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordFinder.php

@@ -164,10 +164,8 @@ public function findUidsOfDemoBeGroups(): array
             ->executeQuery()
             ->fetchAllAssociative();
         $result = [];
-        if (is_array($rows)) {
-            foreach ($rows as $row) {
-                $result[] = $row['uid'];
-            }
+        foreach ($rows as $row) {
+            $result[] = $row['uid'];
         }
         return $result;
     }
@@ -192,10 +190,8 @@ public function findUidsOfDemoBeUsers(): array
             ->executeQuery()
             ->fetchAllAssociative();
         $result = [];
-        if (is_array($rows)) {
-            foreach ($rows as $row) {
-                $result[] = $row['uid'];
-            }
+        foreach ($rows as $row) {
+            $result[] = $row['uid'];
         }
         return $result;
     }
@@ -221,10 +217,8 @@ public function findUidsOfStaticdata(): array
             ->executeQuery()
             ->fetchAllAssociative();
         $result = [];
-        if (is_array($rows)) {
-            foreach ($rows as $row) {
-                $result[] = $row['uid'];
-            }
+        foreach ($rows as $row) {
+            $result[] = $row['uid'];
         }
         return $result;
     }
@@ -296,11 +290,8 @@ public function findUidsOfFrontendPages(array $types = ['tx_styleguide_frontend_
         }
 
         $rows = $queryBuilder->orderBy('pid', 'DESC')->executeQuery()->fetchAllAssociative();
-        $result = [];
-        if (is_array($rows)) {
-            $result = array_column($rows, 'uid');
-            sort($result);
-        }
+        $result = array_column($rows, 'uid');
+        sort($result);
 
         return $result;
     }

typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php

@@ -91,7 +91,7 @@ public function render(): string
 
         $codeMirrorConfig = [
             'mode' => GeneralUtility::jsonEncodeForHtmlAttribute($mode->getModule(), false),
-            'readonly' => true,
+            'readonly' => 'readonly',
         ];
         $attributes = [
             'wrap' => 'off',

typo3/sysext/styleguide/Classes/ViewHelpers/ExampleViewHelper.php

@@ -101,7 +101,7 @@ public function render(): string
 
             $codeMirrorConfig = [
                 'mode' => GeneralUtility::jsonEncodeForHtmlAttribute($mode->getModule(), false),
-                'readonly' => true,
+                'readonly' => 'readonly',
             ];
             $attributes = [
                 'wrap' => 'off',