[TASK] Adjust EnumType and SetType type schema handling

With `doctrine/dbal 4.2.0` the `enum` has been added directly
in DBAL, implementing it slightly different than the original
TYPO3 implementation, which has been mitigated with #105279
and adopted for the `set` type in advance with #105294.

TYPO3 still needs to adopt the options reading existing database
schema provided by a trait to the extended platform classes and
missed to pass the `enum` and `set` option values as `values` to
the `Column` objects instead as `platformOption` key, hidden by
the fact that getting the array representation of a column merges
the platformOptions on the same level with the direct value options.

Upcoming `doctrine/dbal` introduces more phpdoc-block array shapes,
narrowing down possible (allowed) array keys for `platformOptions`
and failing with phpstan in core tests while not beeing a technical
issue.

This change adjusts related code within the `ext_tables.sql` related
`TableBuilder` and the platform trait reading the values and setting
it to `Column` objects as value property instead of `platformOption`.

Considered as task and not as bugfix due to the fact that this is
only static code analysis related and not technically breaking.

Minor left-over in the `SetType` implementation for `doctrine/dbal 4.0`
is removed along the way.

Tested and extracted from doctrine/dbal 4.3.x test,
see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88596

[1] doctrine/dbal#6536
[2] https://github.com/doctrine/dbal/releases/tag/4.2.0

Resolves: #106486
Related: #105294
Related: #105279
Releases: main, 13.4
Change-Id: Ib40d8d684fdce840e4050387416227d56e39698b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88905
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>

Author: sbuerk

typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php

@@ -179,10 +179,10 @@ protected function addColumn(CreateColumnDefinitionItem $item): Column
         }
 
         if ($item->dataType instanceof SetDataType) {
-            $column->setPlatformOption('values', $item->dataType->getValues());
+            $column->setValues($item->dataType->getValues());
         }
         if ($item->dataType instanceof EnumDataType) {
-            $column->setPlatformOption('values', $item->dataType->getValues());
+            $column->setValues($item->dataType->getValues());
         }
 
         if ($item->index) {

typo3/sysext/core/Classes/Database/Schema/SchemaManager/CustomDoctrineTypesColumnDefinitionTrait.php

@@ -84,7 +84,7 @@ protected function processCustomDoctrineTypesColumnDefinition(
         $doctrineType = $this->determineColumnType($dbType, $tableColumn);
 
         $column = new Column($tableColumn['field'] ?? '', Type::getType($doctrineType), $options);
-        $column->setPlatformOption('values', $this->getUnquotedEnumerationValues($tableColumn['type']));
+        $column->setValues($this->getUnquotedEnumerationValues($tableColumn['type']));
 
         return $column;
     }

typo3/sysext/core/Classes/Database/Schema/Types/SetType.php

@@ -48,14 +48,4 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla
         return sprintf('SET(%s)', implode(', ', $quotedValues));
 
     }
-
-    /**
-     * Gets the name of this type.
-     * @todo Remove this method with doctrine/dbal 4.0 upgrade.
-     * @see https://github.com/doctrine/dbal/blob/3.8.x/UPGRADE.md#deprecated-typegetname
-     */
-    public function getName(): string
-    {
-        return static::TYPE;
-    }
 }

typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/MySQLSchemaManagerTest.php

@@ -78,11 +78,11 @@ public function buildsColumnForEnumDataType(string $platform): void
         $column = $subject->callProcessCustomDoctrineTypesColumnDefinitionFromTraitDirectly(['Type' => "enum('value1', 'value2','value3')"]);
         self::assertInstanceOf(Column::class, $column);
         self::assertInstanceOf(EnumType::class, $column->getType());
-        self::assertSame(['value1', 'value2', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value2', 'value3'], $column->getValues());
 
         $column = $subject->callProtectedGetPortableTableColumnDefinition(['Type' => "enum('value1', 'value2','value3')"]);
         self::assertInstanceOf(EnumType::class, $column->getType());
-        self::assertSame(['value1', 'value2', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value2', 'value3'], $column->getValues());
     }
 
     #[DataProvider('platformDataProvider')]
@@ -103,11 +103,11 @@ public function buildsColumnForSetDataType(string $platform): void
         $column = $subject->callProcessCustomDoctrineTypesColumnDefinitionFromTraitDirectly(['Type' => "set('value1', 'value3')"]);
         self::assertInstanceOf(Column::class, $column);
         self::assertInstanceOf(SetType::class, $column->getType());
-        self::assertSame(['value1', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value3'], $column->getValues());
 
         $column = $subject->callProtectedGetPortableTableColumnDefinition(['Type' => "set('value1', 'value3')"]);
         self::assertInstanceOf(SetType::class, $column->getType());
-        self::assertSame(['value1', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value3'], $column->getValues());
     }
     private function createSchemaManager(Connection $connection, DoctrineAbstractMySQLPlatform $platform): FixtureMySQLSchemaManager
     {

typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/PostgreSQLSchemaManagerTest.php

@@ -59,11 +59,11 @@ public function buildsColumnForEnumDataType(string $platform): void
         $column = $subject->callProcessCustomDoctrineTypesColumnDefinitionFromTraitDirectly(['Type' => "enum('value1', 'value2','value3')"]);
         self::assertInstanceOf(Column::class, $column);
         self::assertInstanceOf(EnumType::class, $column->getType());
-        self::assertSame(['value1', 'value2', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value2', 'value3'], $column->getValues());
 
         $column = $subject->callProtectedGetPortableTableColumnDefinition(['Type' => "enum('value1', 'value2','value3')"]);
         self::assertInstanceOf(EnumType::class, $column->getType());
-        self::assertSame(['value1', 'value2', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value2', 'value3'], $column->getValues());
     }
 
     #[DataProvider('platformDataProvider')]
@@ -84,11 +84,11 @@ public function buildsColumnForSetDataType(string $platform): void
         $column = $subject->callProcessCustomDoctrineTypesColumnDefinitionFromTraitDirectly(['Type' => "set('value1', 'value3')"]);
         self::assertInstanceOf(Column::class, $column);
         self::assertInstanceOf(SetType::class, $column->getType());
-        self::assertSame(['value1', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value3'], $column->getValues());
 
         $column = $subject->callProtectedGetPortableTableColumnDefinition(['Type' => "set('value1', 'value3')"]);
         self::assertInstanceOf(SetType::class, $column->getType());
-        self::assertSame(['value1', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value3'], $column->getValues());
     }
 
     public static function platformDataProvider(): \Generator

typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/SQLiteSchemaManagerTest.php

@@ -56,11 +56,11 @@ public function buildsColumnForEnumDataType(): void
         $column = $subject->callProcessCustomDoctrineTypesColumnDefinitionFromTraitDirectly(['Type' => "enum('value1', 'value2','value3')"]);
         self::assertInstanceOf(Column::class, $column);
         self::assertInstanceOf(EnumType::class, $column->getType());
-        self::assertSame(['value1', 'value2', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value2', 'value3'], $column->getValues());
 
         $column = $subject->callProtectedGetPortableTableColumnDefinition(['Type' => "enum('value1', 'value2','value3')"]);
         self::assertInstanceOf(EnumType::class, $column->getType());
-        self::assertSame(['value1', 'value2', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value2', 'value3'], $column->getValues());
     }
 
     #[Test]
@@ -80,11 +80,11 @@ public function buildsColumnForSetDataType(): void
         $column = $subject->callProcessCustomDoctrineTypesColumnDefinitionFromTraitDirectly(['Type' => "set('value1', 'value3')"]);
         self::assertInstanceOf(Column::class, $column);
         self::assertInstanceOf(SetType::class, $column->getType());
-        self::assertSame(['value1', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value3'], $column->getValues());
 
         $column = $subject->callProtectedGetPortableTableColumnDefinition(['Type' => "set('value1', 'value3')"]);
         self::assertInstanceOf(SetType::class, $column->getType());
-        self::assertSame(['value1', 'value3'], $column->getPlatformOption('values'));
+        self::assertSame(['value1', 'value3'], $column->getValues());
     }
 
     private function createSchemaManager(Connection $connection, DoctrineSQLitePlatform $platform): FixtureSQLiteSchemaManager