-
Notifications
You must be signed in to change notification settings - Fork 14
chore: update typst-docs-web to 230699f
#335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
? mise ERROR unsupported json value: Array [Object {"title": String("GitHub (typst-jp/docs)"), "url": String("https://github.com/typst-jp/docs")}, Object {"title": String("Discord (くみはんクラブ)"), "url": String("https://discord.gg/9xF7k4aAuH")}]
mise ERROR Run with --verbose or MISE_VERBOSE=1 for more information |
|
We need to verify the implementation of dotenvy.
|
|
We originally planned to merge this PR immediately, but encountered unexpected behavior in mise. In the future, I'd like to fix mise or its upstream dependencies, but we'll likely need to implement a workaround by parsing with jq or similar. |
Not really. According to https://github.com/jdx/mise/blob/7841a21e/src/config/env_directive/file.rs, mise uses dotenvy only for match v {
serde_json::Value::String(s) => s,
serde_json::Value::Number(n) => n.to_string(),
serde_json::Value::Bool(b) => b.to_string(),
_ => bail!("unsupported json value: {v:?}"),
}, |
|
I understand the situation. I'll consider submitting a PR later, but I think mise will need to make a decision regarding the compatibility with env. cc: @gomazarashi @kimushun1101 @ultimatile Because of these circumstances, I've slightly modified the commands in mise tasks. This shouldn't affect external behavior in any way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the typst-docs-web submodule to commit 230699f and adjusts the project configuration to accommodate changes in the metadata structure. The main change involves restructuring social links from individual fields to an array format.
- Updated
typst-docs-websubmodule reference to commit230699f - Restructured metadata to use a
socialLinksarray instead of individual URL fields - Modified build configuration to work around mise limitations with JSON arrays
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/typst-docs-web | Updated submodule commit reference to 230699f |
| website/metadata.json | Restructured GitHub and Discord URLs into a socialLinks array |
| mise.toml | Added jq dependency and updated task to parse metadata inline, commented out vars configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes
typst-docs-webto commit230699f