Skip to content

Conversation

@3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented Dec 3, 2025

Changes

  • Updated typst-docs-web to commit 230699f

@3w36zj6
Copy link
Member Author

3w36zj6 commented Dec 3, 2025

?

mise ERROR unsupported json value: Array [Object {"title": String("GitHub (typst-jp/docs)"), "url": String("https://github.com/typst-jp/docs")}, Object {"title": String("Discord (くみはんクラブ)"), "url": String("https://discord.gg/9xF7k4aAuH")}]
mise ERROR Run with --verbose or MISE_VERBOSE=1 for more information

@3w36zj6
Copy link
Member Author

3w36zj6 commented Dec 3, 2025

We need to verify the implementation of dotenvy.

INFO

This uses dotenvy under the hood. If you have problems with the way env._.file works, you will likely need to post an issue there, not to mise since there is not much mise can do about the way that crate works.

Environments | mise-en-place
https://mise.jdx.dev/environments/#env-file

@3w36zj6
Copy link
Member Author

3w36zj6 commented Dec 3, 2025

@YDX-2147483647

We originally planned to merge this PR immediately, but encountered unexpected behavior in mise.

In the future, I'd like to fix mise or its upstream dependencies, but we'll likely need to implement a workaround by parsing with jq or similar.

@YDX-2147483647
Copy link
Contributor

YDX-2147483647 commented Dec 4, 2025

This uses dotenvy under the hood.

Not really. According to https://github.com/jdx/mise/blob/7841a21e/src/config/env_directive/file.rs, mise uses dotenvy only for .env files.
For json files, it uses serde_json::from_str and rejects any values other than str/num/bool.

                        match v {
                            serde_json::Value::String(s) => s,
                            serde_json::Value::Number(n) => n.to_string(),
                            serde_json::Value::Bool(b) => b.to_string(),
                            _ => bail!("unsupported json value: {v:?}"),
                        },

@3w36zj6
Copy link
Member Author

3w36zj6 commented Dec 4, 2025

I understand the situation. I'll consider submitting a PR later, but I think mise will need to make a decision regarding the compatibility with env.
As a quick workaround, I've replaced it with parsing using jq. Does this seem okay to you?

cc: @gomazarashi @kimushun1101 @ultimatile

Because of these circumstances, I've slightly modified the commands in mise tasks. This shouldn't affect external behavior in any way.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the typst-docs-web submodule to commit 230699f and adjusts the project configuration to accommodate changes in the metadata structure. The main change involves restructuring social links from individual fields to an array format.

  • Updated typst-docs-web submodule reference to commit 230699f
  • Restructured metadata to use a socialLinks array instead of individual URL fields
  • Modified build configuration to work around mise limitations with JSON arrays

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
website/typst-docs-web Updated submodule commit reference to 230699f
website/metadata.json Restructured GitHub and Discord URLs into a socialLinks array
mise.toml Added jq dependency and updated task to parse metadata inline, commented out vars configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@3w36zj6 3w36zj6 merged commit 03e9505 into main Dec 5, 2025
9 of 10 checks passed
@3w36zj6 3w36zj6 deleted the feature/update-typst-docs-web branch December 5, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants