-
-
Couldn't load subscription status.
- Fork 11
Remove deprecations #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecations #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw you sneaked in another little change there :)
|
Just so this is written here as well, let's wait until Typst 0.14 is released before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that, as per Laurenz's message on Discord, you should update the changelog accordingly.
|
Done, thanks for the reminder! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too sure on the exact phrasing, but it might be worthwhile to be explicit when variants of the mentioned symbols were removed as well.
|
Hmmm, not sure I like the wording there. I think we should stick to variants being of the symbol and not of each other (cf. the How about something like |
I think this is fine, although there is an ambiguity regarding whether I don't think commutativity is an issue because order never matters for modifiers, so removing |
Then what do you think about doubling it up, so "
Yeah, I was more thinking about users who may not know that and assume |
I think that's fine |
|
Done. For the case of a single variant, I mentioned it by name; Not sure if this is the best approach, esp. for |
|
(Also I went ahead and grouped |
|
This needs an approval to be merged |
Now that we have a version out with these as deprecated, we can immediately remove them for the next version.
In fact, it's important to do this right away before we add new deprecations so we don't have to keep track of what was deprecated when.
As discussed on Discord, this should also not be merged before Typst 0.14 is out since there might be a need for further non-breaking codex bugfixes before then.