Skip to content

Conversation

@T0mstone
Copy link
Collaborator

@T0mstone T0mstone commented Oct 8, 2025

Now that we have a version out with these as deprecated, we can immediately remove them for the next version.

In fact, it's important to do this right away before we add new deprecations so we don't have to keep track of what was deprecated when.

As discussed on Discord, this should also not be merged before Typst 0.14 is out since there might be a need for further non-breaking codex bugfixes before then.

Copy link
Collaborator

@knuesel knuesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you sneaked in another little change there :)

@MDLC01
Copy link
Collaborator

MDLC01 commented Oct 9, 2025

Just so this is written here as well, let's wait until Typst 0.14 is released before merging this.

Copy link
Collaborator

@MDLC01 MDLC01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that, as per Laurenz's message on Discord, you should update the changelog accordingly.

@T0mstone
Copy link
Collaborator Author

Done, thanks for the reminder!

Copy link
Collaborator

@MDLC01 MDLC01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure on the exact phrasing, but it might be worthwhile to be explicit when variants of the mentioned symbols were removed as well.

@T0mstone
Copy link
Collaborator Author

T0mstone commented Oct 12, 2025

Hmmm, not sure I like the wording there. I think we should stick to variants being of the symbol and not of each other (cf. the main.rs doc comment).

How about something like plus.circle.* instead? (also not perfect because of commutativity, but I couldn't think of anything better)

@MDLC01
Copy link
Collaborator

MDLC01 commented Oct 12, 2025

How about something like plus.circle.* instead? (also not perfect because of commutativity, but I couldn't think of anything better)

I think this is fine, although there is an ambiguity regarding whether plus.circle is included.

I don't think commutativity is an issue because order never matters for modifiers, so removing plus.circle.* also removes plus.*.circle.*.

@T0mstone
Copy link
Collaborator Author

there is an ambiguity regarding whether plus.circle is included.

Then what do you think about doubling it up, so "plus.circle, plus.circle.*"?

I don't think commutativity is an issue because order never matters for modifiers, so removing plus.circle.* also removes plus.*.circle.*.

Yeah, I was more thinking about users who may not know that and assume plus.big.circle to be exempt.

@MDLC01
Copy link
Collaborator

MDLC01 commented Oct 12, 2025

Then what do you think about doubling it up, so "plus.circle, plus.circle.*"?

I think that's fine

@T0mstone
Copy link
Collaborator Author

Done. For the case of a single variant, I mentioned it by name; Not sure if this is the best approach, esp. for times.circle, where it kind of sounds like there are other such variants that haven't been removed...

@T0mstone
Copy link
Collaborator Author

(Also I went ahead and grouped kai and Kai into a single bullet point because it felt right)

@MDLC01
Copy link
Collaborator

MDLC01 commented Oct 27, 2025

This needs an approval to be merged

@MDLC01 MDLC01 merged commit 88e2bef into typst:main Oct 27, 2025
1 check passed
@T0mstone T0mstone deleted the remove-deprecations branch October 27, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants