Fix empty sort key condition isolation issue#533
Merged
tywalch merged 1 commit intotywalch:masterfrom Dec 13, 2025
Merged
Conversation
When comparison queries (gt, lt, etc.) were called with an empty object, the sort key prefix omitted the first composite attribute label (e.g., "$tasks_1" instead of "$tasks_1#team_"). This caused queries to incorrectly match items across different entity versions, breaking entity isolation. Fixed by checking if composite attributes are provided before setting excludeLabelTail in _makeIndexKeysWithoutTail.
✅ Deploy Preview for electrodb-dev canceled.
|
Owner
|
Great work! |
anatolzak
pushed a commit
to anatolzak/electrodb
that referenced
this pull request
Jan 1, 2026
When comparison queries (gt, lt, etc.) were called with an empty object, the sort key prefix omitted the first composite attribute label (e.g., "$tasks_1" instead of "$tasks_1#team_"). This caused queries to incorrectly match items across different entity versions, breaking entity isolation. Fixed by checking if composite attributes are provided before setting excludeLabelTail in _makeIndexKeysWithoutTail.
tywalch
added a commit
that referenced
this pull request
Jan 3, 2026
Owner
|
Flagging this PR, it may need to be rolled back: #540 |
tywalch
added a commit
that referenced
this pull request
Jan 4, 2026
tywalch
added a commit
that referenced
this pull request
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparison queries (gt, lt, etc.) were called with an empty object,
the sort key prefix omitted the first composite attribute label (e.g.,
"$tasks_1" instead of "$tasks_1#team_"). This caused queries to
incorrectly match items across different entity versions, breaking
entity isolation.
Fixed by checking if composite attributes are provided before setting
excludeLabelTail in _makeIndexKeysWithoutTail.