Custom render page function & with-next-layouts example #2

tz5514 · 2017-12-19T23:05:15Z

No description provided.

jdeal

@tz5514 Thanks for trying this approach!

I have some minor naming suggestions. More importantly, I tend to think the raw props should be passed to renderPage.

jdeal · 2017-12-20T00:07:15Z

lib/app.js

@@ -72,9 +72,14 @@ class Container extends Component {

  render () {
    const { Component, props, url } = this.props
+    const component = (typeof Component.renderPage === 'function') ? (


Minor nitpick, could we name this page instead of component?

jdeal · 2017-12-20T00:09:50Z

lib/app.js

@@ -72,9 +72,14 @@ class Container extends Component {

  render () {
    const { Component, props, url } = this.props
+    const component = (typeof Component.renderPage === 'function') ? (
+      Component.renderPage({ Component, props, url })


Why isn't this just:

Component.renderPage(this.props)

In other word, why do most of this.props get packed into props? It seems like to me that renderPage should get the same props as Component gets + the Component itself, which is just the original this.props.

200% agree! 🔥🔥🔥

jdeal · 2017-12-20T00:11:01Z

examples/persistent-layouts/modules/next-layouts.js

@@ -0,0 +1,81 @@
+import React from 'react'
+const defualtOptions = {


tz5514 · 2017-12-20T00:36:10Z

@jdeal fixed them all. thanks for suggestions 😄 !

frol · 2018-01-05T10:37:55Z

@tz5514 Let's PR it to the upstream, so this get's reviewed by the core team.

tz5514 · 2018-01-05T12:18:49Z

@frol got it!

frol · 2018-01-09T22:02:41Z

@tz5514 Do you need help with anything?

tz5514 · 2018-01-09T22:19:14Z

@frol I'm writing for new PR right now ha ha.
BTW, should I close the old PR (vercel#3471)?

frol · 2018-01-09T22:32:04Z

Yeah, I would close both vercel#3461 and vercel#3471 and reference the new PR from there.

tz5514 · 2018-01-09T22:32:07Z

@frol The new PR is here. vercel#3552
Could you help me to check this out? thanks!

* Add a nerv example. * Fix for indentation/style * Fix for name

…ercel#3821)

* Use indexOf instead of startsWith This fixes an IE11 regression, see vercel#3755 * Lint the code

…cel#3635)

frol · 2018-03-22T13:14:36Z

@tz5514 Oh my, please, do rebase next time instead of merge.

tz5514 · 2018-03-22T13:15:37Z

@frol oops, my bad

* Update readme for Next 5 * remove specific version mention

* Remove deprected use of apollo-client-preset, and refactor Changes * Remove deprected use of apollo-client-preset in favor of apollo-boost * Refactor for usage of react-apollo@2.1 * Use standard Just ran standard --fix

* New example: with-now-env * updated the example with-now-env

* Fix vercel#3900 return 404 on asset hash mismatch in prod * Make INVALID_BUILD_ID return 404

* Better support React 16.3.0 mridgway/hoist-non-react-statics#43 * Lock version

@jthegedus

* Fix serve command From the Firebase docs, you must use --only in order to run the local function emulator. See https://firebase.google.com/docs/functions/local-emulator * Add production env for firebase serve Doesn't work without this * Update text as suggested by @jthegedus

Makes sure highlight.js/styles/dark.css doesn’t get caught by externals.

…cel#3956) * Add router method to inject code before popstate events * Default _beforePopState, return true * Fix link in README * Re-order `if` statements per feedback

* Allow BUILD_ID to be set in the environment This makes multi server deploys with Capistrano possible. * next.config.js generateBuildId support enable customising the build id via config * Provide default for generateBuildId * This is not used

…l#4092)

Upgrade Babel 6 to Babel 7 (major)

) * Examples: clarify language around Yarn create & npx * add missing READMEs and create-next-app usage * suggest people tag jthegedus in firebase related issues * add yarn alt instructions * cerebraljs example readme & fixes

* Add support for exportPathMap in development * Add comment about what it does

tz5514 changed the title ~~Custom render page function~~ Custom render page function & applyLayout Dec 19, 2017

tz5514 changed the title ~~Custom render page function & applyLayout~~ Custom render page function & persistent-layouts example Dec 19, 2017

tz5514 force-pushed the custom-render-page-function branch from a1fc015 to 8ca8649 Compare December 19, 2017 23:17

tz5514 mentioned this pull request Dec 19, 2017

Persistent layout (top-level app component) supporting page by page without any workaround vercel/next.js#3471

Closed

jdeal reviewed Dec 20, 2017

View reviewed changes

tz5514 force-pushed the custom-render-page-function branch from 8ca8649 to 713d81b Compare December 20, 2017 00:33

tz5514 changed the title ~~Custom render page function & persistent-layouts example~~ Custom render page function & with-next-layouts example Dec 20, 2017

tz5514 force-pushed the custom-render-page-function branch from 713d81b to 53db6d5 Compare January 5, 2018 18:50

tz5514 force-pushed the custom-render-page-function branch from 53db6d5 to 8649e43 Compare January 12, 2018 15:25

arunoda and others added 9 commits January 13, 2018 20:56

Move security related test cases into a its own file.

33f8f28

Removes the unused renderScript function

77c10b2

Add a nerv example. (vercel#3573)

93990ab

* Add a nerv example. * Fix for indentation/style * Fix for name

Merge branch 'canary'

c5ddfea

Release 5.0.0

4697cbc

Add multi-zones docs. (vercel#3688)

7a1d9c1

with emotion example - hoist styles out of the index page component (v…

523b615

…ercel#3821)

Use indexOf instead of startsWith (vercel#3758)

9fb8b93

* Use indexOf instead of startsWith This fixes an IE11 regression, see vercel#3755 * Lint the code

Merge branch 'canary' into master

b75a887

tz5514 pushed a commit that referenced this pull request Mar 22, 2018

upgraded flow version and updated code to use of React.Node (#2) (ver…

c4830c3

…cel#3635)

igor-toporet and others added 2 commits March 23, 2018 09:24

Update readme (do not mention specific version) (vercel#4038)

b134105

* Update readme for Next 5 * remove specific version mention

migrated from apollo-client-preset to apollo-boost (vercel#4047)

9470b91

timneutkens and others added 28 commits March 31, 2018 00:00

Use printAndExit with error (vercel#4086)

812db74

Remove deprected and refactor with-apollo-auth (vercel#4070)

b321e6e

* Remove deprected use of apollo-client-preset, and refactor Changes * Remove deprected use of apollo-client-preset in favor of apollo-boost * Refactor for usage of react-apollo@2.1 * Use standard Just ran standard --fix

clarify .next in .gitignore text (vercel#4087)

7e67152

Updated example with-now-env (vercel#4081)

b43af82

* New example: with-now-env * updated the example with-now-env

Fix vercel#3900 return 404 on asset hash mismatch in prod (vercel#3941)

9ec81c0

* Fix vercel#3900 return 404 on asset hash mismatch in prod * Make INVALID_BUILD_ID return 404

Get pages before entry function (vercel#4089)

0b9b902

Release 6.0.0-canary.1

a48dc31

Better support React 16.3.0 (vercel#4090)

bd50a7c

* Better support React 16.3.0 mridgway/hoist-non-react-statics#43 * Lock version

Upgrade Next in with-firebase-hosting

c07cf5e

Merge branch 'canary' of github.com:zeit/next.js into canary

43fe9ac

Match externals ending in .js not everything with .js (vercel#4091)

a785f30

Makes sure highlight.js/styles/dark.css doesn’t get caught by externals.

Add Router method to execute custom logic before popstate events (ver…

085b2f8

…cel#3956) * Add router method to inject code before popstate events * Default _beforePopState, return true * Fix link in README * Re-order `if` statements per feedback

Make sure hot-self-accept-loader cleans up the route correctly (verce…

c3318d8

…l#4092)

6.0.0-canary.2

2fa49d7

Check if matched before reading value (vercel#4096)

9d4891f

Upgrade Babel 6 to Babel 7 (major) (vercel#4050)

2d8c19a

Upgrade Babel 6 to Babel 7 (major)

5.0.1-canary.18

09989f5

Bring back 6.0.0-canary.2

af2fa8e

6.0.0-canary.3

746a6c0

Speed up tests (vercel#4102)

4e8d075

Redo vercel#4090 (vercel#4104)

cb566bd

Update doc for @zeit/next-stylus (vercel#4107)

b393833

Add support for exportPathMap in development (vercel#4094)

dac2f39

* Add support for exportPathMap in development * Add comment about what it does

add renderPage supporting

5da2490

add with-next-layouts example

4cc09fe

tz5514 force-pushed the custom-render-page-function branch from 3d6601f to 4cc09fe Compare April 5, 2018 23:07

tz5514 closed this Apr 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom render page function & with-next-layouts example #2

Custom render page function & with-next-layouts example #2

tz5514 commented Dec 19, 2017

jdeal left a comment

jdeal Dec 20, 2017

jdeal Dec 20, 2017

tz5514 Dec 20, 2017

jdeal Dec 20, 2017

tz5514 Dec 20, 2017

tz5514 commented Dec 20, 2017

frol commented Jan 5, 2018

tz5514 commented Jan 5, 2018

frol commented Jan 9, 2018

tz5514 commented Jan 9, 2018

frol commented Jan 9, 2018

tz5514 commented Jan 9, 2018

frol commented Mar 22, 2018

tz5514 commented Mar 22, 2018

		@@ -0,0 +1,81 @@
		import React from 'react'
		const defualtOptions = {

Custom render page function & with-next-layouts example #2

Custom render page function & with-next-layouts example #2

Conversation

tz5514 commented Dec 19, 2017

jdeal left a comment

Choose a reason for hiding this comment

jdeal Dec 20, 2017

Choose a reason for hiding this comment

jdeal Dec 20, 2017

Choose a reason for hiding this comment

tz5514 Dec 20, 2017

Choose a reason for hiding this comment

jdeal Dec 20, 2017

Choose a reason for hiding this comment

tz5514 Dec 20, 2017

Choose a reason for hiding this comment

tz5514 commented Dec 20, 2017

frol commented Jan 5, 2018

tz5514 commented Jan 5, 2018

frol commented Jan 9, 2018

tz5514 commented Jan 9, 2018

frol commented Jan 9, 2018

tz5514 commented Jan 9, 2018

frol commented Mar 22, 2018

tz5514 commented Mar 22, 2018