Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Apple Silicon/Retina #125

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Support for Apple Silicon/Retina #125

merged 2 commits into from
Sep 17, 2023

Conversation

valb3r
Copy link
Contributor

@valb3r valb3r commented Sep 5, 2023

  • Added support for HiDPI
  • Added support for Apple Silicon

For HiDPI it is necessary to use glfwGetWindowContentScale parameter (i.e. jMonkeyEngine/jmonkeyengine#893)

@valb3r valb3r mentioned this pull request Sep 5, 2023
@tzaeschke
Copy link
Owner

Hi @valb3r , thanks for reporting and the PR!
I'm currently quite busy, I'll have a look in the next few days.

@tzaeschke
Copy link
Owner

Hi @valb3r , I had a look, and as it is it gives me weird scaling on Windows and Ubuntu, the windows all appear to be "zoomed in".
However, adding the following in LwJGL.java, line 143 fixes the issue for me:
glfwWindowHint(GLFW_SCALE_TO_MONITOR, GLFW_TRUE);

Can you try to add this line and verify whether that still works on MacOS?

@valb3r
Copy link
Contributor Author

valb3r commented Sep 9, 2023

@tzaeschke Added that line.
It didn't change appearance neither on MacOs neither on Linux (Ubuntu 20.04) - with or without that line everything looks fine on Ubuntu and MacOs. Looks like some weird OpenGL peculiarity

@tzaeschke tzaeschke merged commit 11648bf into tzaeschke:master Sep 17, 2023
@tzaeschke
Copy link
Owner

@valb3r Thanks a lot for the PR!

It didn't change appearance neither on MacOs neither on Linux (Ubuntu 20.04) - with or without that line everything looks fine on Ubuntu and MacOs. Looks like some weird OpenGL peculiarity

I use screen scaling on some of my screens, it seemed to be the same amount by which the views were scaled, that may be the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants