Skip to content

Conversation

@andrew-gardener
Copy link

@andrew-gardener andrew-gardener commented Jun 3, 2021

  • Properly escape - character
  • Allow . character for set ids

Closes #23

@andrew-gardener andrew-gardener requested a review from xcompass June 3, 2021 18:43
Copy link
Member

@xcompass xcompass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Properly escape `-` character
- Allow `.` character for set ids
@andrew-gardener andrew-gardener force-pushed the lti-set-name-sanitizer branch from 084cbae to c94f1dc Compare June 4, 2021 17:33
@andrew-gardener andrew-gardener merged commit cdb344f into ubc Jun 4, 2021
@andrew-gardener andrew-gardener deleted the lti-set-name-sanitizer branch June 4, 2021 17:33
ionparticle pushed a commit that referenced this pull request Nov 9, 2021
ionparticle pushed a commit that referenced this pull request Jul 26, 2022
Switch to a sponsor button that is directly in the page, instead of in an iframe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Sanitization of Canvas Assignment Names

3 participants