Skip to content

Update idls#882

Merged
natemort merged 3 commits intocadence-workflow:masterfrom
natemort:async
Apr 19, 2024
Merged

Update idls#882
natemort merged 3 commits intocadence-workflow:masterfrom
natemort:async

Conversation

@natemort
Copy link
Member

What changed?

  • Update the IDLs to begin work to bring the Async APIs to the Java client.

Why?

  • The new thrift definitions are necessary to add support to the client for the new methods.

How did you test it?

  • Unit tests

Potential risks

  • Users attempting to use these methods will encounter exceptions as the functionality isn't actually implemented.

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 2259

Details

  • 0 of 51 (0.0%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 60.125%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/uber/cadence/internal/compatibility/Thrift2ProtoAdapter.java 0 6 0.0%
src/main/java/com/uber/cadence/internal/testservice/TestWorkflowService.java 0 6 0.0%
src/main/java/com/uber/cadence/serviceclient/IWorkflowServiceBase.java 0 6 0.0%
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java 0 6 0.0%
src/main/java/com/uber/cadence/internal/sync/TestActivityEnvironmentInternal.java 0 9 0.0%
src/main/java/com/uber/cadence/internal/sync/TestWorkflowEnvironmentInternal.java 0 9 0.0%
src/main/java/com/uber/cadence/migration/MigrationIWorkflowService.java 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadContext.java 2 81.58%
Totals Coverage Status
Change from base Build 2251: -0.2%
Covered Lines: 11455
Relevant Lines: 19052

💛 - Coveralls

@natemort natemort merged commit f715975 into cadence-workflow:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants