Fix randomly failed icon layer render test #4079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
requested changes
Dec 31, 2019
| const imageData = await loadImage(icon.url); | ||
|
|
||
| const data = resizeImage(ctx, imageData, width, height); | ||
| if (i === icons.length - 1) { |
There was a problem hiding this comment.
- This marks loaded when the last image is loaded, not when all images are loaded.
- What happens when the icon set changes?
There was a problem hiding this comment.
- What happens when the icon set changes?
reset loaded to false when there are more icons required to be loaded.
added 2 commits
January 2, 2020 14:12
xintongxia
force-pushed
the
xx/icon-render-test
branch
from
5d3d8e1 to
09d58d7
Compare
xintongxia
force-pushed
the
xx/icon-render-test
branch
from
9137728 to
fbf3290
Compare
| let loaded = 0; | ||
| for (const icon of icons) { | ||
| loadImage(icon.url).then(imageData => { | ||
| loaded++; |
There was a problem hiding this comment.
More scenarios to consider:
loadedwill never be set if one of the images fails to load, e.g. url is not found. Is that intended?- This logic breaks if data is changed and a new batch of icons start loading. How do you handle that?
xintongxia
force-pushed
the
xx/icon-render-test
branch
from
7cca557 to
6b6aa21
Compare
added 2 commits
January 3, 2020 10:51
|
|
||
| get loaded() { | ||
| const requestedIcons = Object.keys(this._mapping).length; | ||
| return this._autoPacking && requestedIcons && this._loadedIcons === requestedIcons; |
There was a problem hiding this comment.
I'd recommend tracking the number of pending requests rather than the number of fulfilled requests:
this._pendingCount++;
loadSomething(...).finally(() => this._pendingCount--);That way you don't need to know how to calculate the total number of requests here with _autoPacking and _mapping. The auto packing logic may change in the future and maintainers may forget to update this function, given that there are no tests. If requests are tracked where they start, it will be much more robust.
added 2 commits
January 3, 2020 11:14
Pessimistress
approved these changes
Jan 3, 2020
1chandu
pushed a commit
that referenced
this pull request
Jan 8, 2020
chrisgervang
pushed a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4039
Background
Change List
IconManager: add aloadedfield indicating if the icons are fully loaded.