Skip to content

Conversation

howtimeflies0
Copy link

Copy link
Contributor

@1chandu 1chandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one typo.

* `CompositeLayer.renderLayers` can now return a nested arrays with `null` values. deck.gl will automatically flatten and filter the array. This is a small convenience that makes the `renderLayers methods in complex composite layers a little more readable.
## WebGL2 support provided by luma.gl v4

While deck.gl v4.1 is not a backward-compatible minor release, its rendering functionality is backed by luma.gl v4, a WebGL2-enabled rendering framework. One all browsers that supports WebGL2, deck.gl will obtain WebGL2 context and utilize WebGL2 functionalities. To know more about WebGL2, please check [here](https://www.khronos.org/registry/webgl/specs/latest/2.0/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : One all -> Once all

const model = new Model(gl, {
vs: vertexShader,
fs: fragmentShader,
modules: ['fp64', ...],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a list of available modules listed somewhere?

## Upgrading from deck.gl v4 to v4.1

A highly compatible release, the biggest change is that deck.gl v4.1 brings in luma.gl v4. It is a highly compatible release but there are some changes. If you are writing deck.gl layers using luma.gl classes, please refer to the Upgrade Guide for luma.gl.
deck.gl v4.1 is a backward-compatible release. Most of the functionality and APIs remain unchanged but there are smaller changes that might requires developers' attention if they /**develop their own layers**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backward compatible release with v4.0 (maybe redundant for those who's familiar with semver)

* `CompositeLayer.renderLayers` can now return a nested arrays with `null` values. deck.gl will automatically flatten and filter the array. This is a small convenience that makes the `renderLayers methods in complex composite layers a little more readable.
## WebGL2 support provided by luma.gl v4

While deck.gl v4.1 is not a backward-compatible minor release, its rendering functionality is backed by luma.gl v4, a WebGL2-enabled rendering framework. One all browsers that supports WebGL2, deck.gl will obtain WebGL2 context and utilize WebGL2 functionalities. To know more about WebGL2, please check [here](https://www.khronos.org/registry/webgl/specs/latest/2.0/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While deck.gl v4.1 is --not-- a backward-compatible minor release

@howtimeflies0 howtimeflies0 merged commit fb1d9e1 into master Jul 21, 2017
howtimeflies0 pushed a commit that referenced this pull request Jul 21, 2017
* Update whats new and upgrade guide
* address comments
@balthazar balthazar deleted the doc-update branch July 31, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants