Text-layer #804
Merged
Text-layer #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howtimeflies0
suggested changes
Jul 24, 2017
rivulet-zhang
force-pushed
the
text-layer
branch
from
46f9819 to
2c1fce5
Compare
|
@shaojingli The style file has been removed (will also remove the same file from the tagmap example). There are some known issues with style diffing, so set |
rivulet-zhang
force-pushed
the
text-layer
branch
from
2c1fce5 to
c07b1b4
Compare
howtimeflies0
approved these changes
Aug 8, 2017
rivulet-zhang
force-pushed
the
text-layer
branch
from
c07b1b4 to
87500bc
Compare
|
Hi @shaojingli I've made a few changes in the vertex shader to fix the icon rotation issue (See #834 ). You can feel free to merge it now. |
ibgreen
approved these changes
Aug 9, 2017
| @@ -0,0 +1,101 @@ | |||
| /* eslint-disable max-len */ | |||
There was a problem hiding this comment.
We have an examples/sample-layers folder, might be a good place.
There was a problem hiding this comment.
Yep. Actually, it would be nice to have it as a core layer so that for other text-related layer dev (e.g., tagmap) we do not need to duplicate the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here comes a text layer for deck.gl. This version is probably more scalable than the existing label layer implementation as it does not require dynamically generating texture for labels. Instead, it uses a font atlas (small, around 50k) to iteratively render letters of the label. The layer is mainly built upon the icon layer and overrides its vertex shader and calculates the offset of each letter in the string.
Let me know if there is anything I need to adjust before merging.