This repository was archived by the owner on Mar 7, 2019. It is now read-only.
Add support for mappings in Location #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profile did not work because the location output contained "M=1". Found that pprof outputs this if there's a "Mapping": https://github.com/golang/go/blob/f78a4c84ac8ed44aaf331989aa32e40081fd8f13/src/cmd/pprof/internal/profile/profile.go#L383 This change ignores the "M=" and uses the next field in that space.
Contributor
|
💯 |
prashantv
added a commit
that referenced
this pull request
Oct 14, 2015
Add support for mappings in Location
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile did not work because the location output contained "M=1". Found
that pprof outputs this if there's a "Mapping":
https://github.com/golang/go/blob/f78a4c84ac8ed44aaf331989aa32e40081fd8f13/src/cmd/pprof/internal/profile/profile.go#L383
This change ignores the "M=" and uses the next field in that space.
r @sectioneight