Set bundle version #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@neakor could you give this a review. |
sbarow
commented
Nov 6, 2018
neakor
previously approved these changes
Nov 6, 2018
neakor
suggested changes
Nov 8, 2018
| <key>CFBundlePackageType</key> | ||
| <string>FMWK</string> | ||
| <key>CFBundleShortVersionString</key> | ||
| <string>1.0</string> |
Contributor
There was a problem hiding this comment.
We should probably set this to 0.6.1 as well.
neakor
approved these changes
Nov 8, 2018
Contributor
Author
|
@neakor can you merge this, I can't. |
Contributor
|
Hmmm the branch CI job is stuck... I'll force merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle version was
$(CURRENT_PROJECT_VERSION)this breaks Carthage versions when validating an App Store version of an app as the version will actually be blank.