Skip to content

Status in url should be lower case #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Status in url should be lower case #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NGitLab/Impl/PipelineClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ private string CreateSearchUrl(PipelineQuery query)
if (query.Scope.HasValue)
queryEntries.Add("scope", query.Scope.Value.ToString());
if (query.Status.HasValue)
queryEntries.Add("status", query.Status.Value.ToString());
queryEntries.Add("status", query.Status.Value.ToString().ToLower());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As good practice, in most cases it's better to use ToLowerInvariant() than ToLower() (which is culture-sensitive).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louis-z We should add the BannedSymbol analyzer to ensure nobody uses this method (and a few other problematic methods)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll add it.

if (!string.IsNullOrWhiteSpace(query.Ref))
queryEntries.Add("ref", query.Ref);
if (!string.IsNullOrWhiteSpace(query.Sha))
Expand Down