Skip to content

Conversation

@artivis
Copy link
Contributor

@artivis artivis commented Sep 27, 2024

No description provided.

Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
@Guillaumebeuzeboc
Copy link
Collaborator

The directory for the gadget is turtlebot3c-gadget, while the name of the gadget in the snapcraft.yaml is turtlebot3c-pi: snapcraft.yaml
Shouldn't the name of the directory be turtlebot3c-pi-gadget?

@artivis
Copy link
Contributor Author

artivis commented Sep 27, 2024

The directory for the gadget is turtlebot3c-gadget, while the name of the gadget in the snapcraft.yaml is turtlebot3c-pi: snapcraft.yaml Shouldn't the name of the directory be turtlebot3c-pi-gadget?

It is not strictly necessary and I'd like to have a common folder name for all branches which simplifies the CI script.

We could also rename all the different gadgets to turtlebot3c-gadget and assume they are differentiated through channels ... Again, not strictly necessary, we can revisit that later.

@artivis artivis merged commit 017c21a into noetic Sep 27, 2024
3 checks passed
@artivis artivis deleted the fix/mv-noetic branch September 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants