-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PXP-7402) Discovery page #803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Search bar - [ ] Show favorites - [ ] Access toggle
- Search bar - Show favorites - Access toggle
- [x] Favorite symbol - [x] Study name is link - [x] Access symbol - [ ] Tags - [ ] Study description
- Favorite symbol - Study name is link - Access symbol - Tags - [~] Study description - May need to find another workaround for the study description
- Favorite symbol - Study name is link - Access symbol - Tags - Study description
- [x] Load study data on component mount - [ ] Plug study data into header - [ ] stats - [ ] tags - [ ] Plug study data into table - [ ] Plug study data in modal - TODO IN FUTURE check user's study access against Arborist
- [x] Load study data on component mount - [ ] Plug study data into header - [ ] stats - [ ] tags - [x] Plug study data into table - [ ] Plug study data in modal - TODO IN FUTURE check user's study access against Arborist
- [x] Load study data on component mount - [ ] Plug study data into header - [x] stats - [ ] tags - [x] Plug study data into table - [ ] Plug study data in modal - TODO IN FUTURE check user's study access against Arborist
- [x] Load study data on component mount - [x] Plug study data into header - [x] stats - [x] tags - [x] Plug study data into table - [ ] Plug study data in modal - TODO IN FUTURE check user's study access against Arborist
- [x] Load study data on component mount - [x] Plug study data into header - [x] stats - [x] tags - [x] Plug study data into table - [ ] Plug study data in modal - TODO IN FUTURE check user's study access against Arborist
- Load study data on component mount - Plug study data into header - stats - tags - Plug study data into table - Plug study data in modal - TODO IN FUTURE check user's study access against Arborist
- Add jsSearch library - Get basic search working - Highlight search results - TODO IN FUTURE Return to page 1 on search
- [x] Refactor access checking: add 'accessible' property to data - [x] Filter table data by access level when buttons selected - [x] Filter table data by selected tag - [ ] Make tags in header selectable
- [x] Refactor access checking: add 'accessible' property to data - [x] Filter table data by access level when buttons selected - [x] Filter table data by selected tag - [~] Make tags in header selectable
- [x] Refactor access checking: add 'accessible' property to data - [x] Filter table data by access level when buttons selected - [x] Filter table data by selected tag - [~] Make tags in header selectable - Try colorSelected / colorUnselected
- Refactor access checking: add 'accessible' property to data - Filter table data by access level when buttons selected - Filter table data by selected tag - Make tags in header selectable
- Open study page in modal when linked to
This was referenced Aug 31, 2021
Merged
This was referenced Sep 13, 2021
This was referenced Sep 20, 2021
This was referenced Mar 18, 2022
This was referenced Apr 1, 2022
Closed
This was referenced Dec 19, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-7402
Adds a beta version of the Discovery page, which shows a list of the studies available on the Gen3 commons. Also adds support for Typescript (compiling w/ babel, tests, and linting). This PR looks a lot bigger than it really is due to test data + Typescript setup -- the files to start with are:
src/Discovery/index.tsx
<- this connects the Discovery page to the metadata-service backend and handles access checkingsrc/Discovery/Discovery.tsx
<- this is the entire Discovery page -- I kept it in one file on purpose, as the Discovery page is still a beta feature and we're going to heavily modify its appearance in the future (adding a grid view, etc).src/Discovery/Discovery.test.tsx
Running at https://mpingram.planx-pla.net/discovery.Working on deploying to my dev env but running into problems with submitting data to MDS. For the moment, please test with these instructions:cdis-manifest
: https://github.com/uc-cdis/cdis-manifest/tree/feat/bdc-staging-discovery-page.HOSTNAME=staging.gen3.biodatacatalyst.nhlbi.nih.gov NODE_ENV=auto bash ./runWebpack.sh
Configuration
To deploy Discovery page:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes
"featureFlags": { "discovery": true }
must be set in the portal config.discoveryConfig.features.authorization.enabled: true
,"useArboristUI": true
must be set in the portal config."discoveryConfig": <DiscoveryConfig>
must be set in the portal config. DiscoveryConfig documentation can be found at https://github.com/uc-cdis/data-portal/blob/master/docs/portal_config.mdguid_type: "discovery_metadata"
. The metadata must all be under the top-level propertygen3_discovery
. (No documentation on this process yet, see this gist for right now https://gist.github.com/Avantol13/a53593837503fede2881f315198247c4)