Config finder make target
#1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opening this up to see if people have any better ideas on how to do this (without some of the flaws) |
|
Neat. Can you add this to build setup? I think this along with ctags can be the same step. |
This dumps the configs at will, not into some file... Did you want this to be more visible (hence printing at the start of build-setup)? |
|
Hmmm good point. Printing into a file probably isn't great for discoverability. This should be added to CI somewhere though. |
abejgonzalez
force-pushed
the
new-hammer
branch
from
6f70eab
to
efb4b7d
Compare
abejgonzalez
force-pushed
the
config-finder
branch
from
81e56cf
to
c39970f
Compare
abejgonzalez
force-pushed
the
config-finder
branch
from
e978209
to
821273c
Compare
jerryz123
approved these changes
Mar 1, 2023
abejgonzalez
force-pushed
the
config-finder
branch
from
2cf8c18
to
17d1b2c
Compare
joonho3020
pushed a commit
that referenced
this pull request
Mar 7, 2023
jerryz123
reviewed
Mar 7, 2023
| CONFIG_FRAG_LEVELS ?= 3 | ||
| .PHONY: find-config-fragments | ||
| find-config-fragments: $(SCALA_SOURCES) | ||
| rm -rf /tmp/scala_files.f |
There was a problem hiding this comment.
I'm afraid of this causing problems for shared installations. Can you make this dump the file within the repo?
sriramsridhar23
pushed a commit
that referenced
this pull request
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new target to help users find some config fragments (also adds to the docs on how to use it).
Unfortunately, I wanted to do this through Scala reflection, however, that isn't possible since you can only look at the subclasses of
sealedtraits/classes. This is a simple solution that covers large majority of configs (assuming config. fragments are defined on a single line - "class NAME extends CONFIG\n"). This doesn't cover configs that don't inherit directly fromConfig... I don't have time to do that right now (or figure out a better way).TODO:
class NAME extends Config\n). Extend this to match on multi-line (is there a scala-parser in Python that we can just read the scala file and see if there is an object that matches this).Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?