Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VLSI input files list emission to avoid bash "too many arguments" error #1348

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

sagark
Copy link
Member

@sagark sagark commented Feb 16, 2023

This makes the expansion of "cat $(VLSI_RTL)" happen as a child of the shell that runs the for loop.

The existing version will sometimes produce a bash "too many arguments" error because the

$(shell cat $(VLSI_RTL)) 

is expanded first and then passed as a giant command to bash.

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?

This makes the expansion of "cat $(VLSI_RTL)" happen as a child of the shell that runs the for loop.

The existing version will sometimes produce a bash "too many arguments" error because the $(shell cat $(VLSI_RTL)) is expanded first and then passed as a giant command to bash.
@sagark sagark changed the title Fix input files list emission to avoid bash "too many arguments" error Fix VLSI input files list emission to avoid bash "too many arguments" error Feb 16, 2023
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, is now a problem due to CIRCT, eh?
Can you also change this in power.mk and sim.mk?

@sagark sagark merged commit f77bb36 into main Feb 16, 2023
@sagark sagark deleted the vlsi-makefile-fix-1 branch February 16, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants