Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Scala-based Config Finder #1424

Merged
merged 2 commits into from
Apr 5, 2023
Merged

New Scala-based Config Finder #1424

merged 2 commits into from
Apr 5, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Apr 4, 2023

make find-config-fragments now searches for all configs using the classpath instead of greps. A slight downside to this approach is that you don't get the filename of the config... but this should still be better and more robust than the grep methodology.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Apr 4, 2023

rebase

✅ Branch has been successfully rebased

@abejgonzalez
Copy link
Contributor Author

@jerryz123 ping

@jerryz123
Copy link
Contributor

Cool. Can you paste here what the generated stuff looks like?

@abejgonzalez
Copy link
Contributor Author

image

@abejgonzalez abejgonzalez merged commit 8a7c98c into main Apr 5, 2023
@abejgonzalez abejgonzalez deleted the new-cfg-finder branch April 20, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants