Ensure sequence is moved to CPU #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the TV script generation project, the generate() function erroneously continues to use the current_seq value without first moving to CPU (if training on GPU). This can lead to an error of the form shown below: "TypeError: can't convert CUDA tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first." Resolves: udacity#118
Contributor
|
Thank you! |
smonasco
pushed a commit
to smonasco/deep-learning-v2-pytorch
that referenced
this pull request
Dec 3, 2019
Ensure sequence is moved to CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the TV script generation project, the generate() function erroneously
continues to use the current_seq value without first moving to CPU (if training
on GPU). This can lead to an error of the form shown below:
"TypeError: can't convert CUDA tensor to numpy. Use Tensor.cpu() to copy the
tensor to host memory first."
Resolves: #118