Skip to content

Updated calculation of train_loss and valid_loss #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Updated calculation of train_loss and valid_loss #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions convolutional-neural-networks/mnist-mlp/mnist_mlp_solution_with_validation.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@
" # perform a single optimization step (parameter update)\n",
" optimizer.step()\n",
" # update running training loss\n",
" train_loss += loss.item()*data.size(0)\n",
" train_loss += loss.item()\n",
" \n",
" ###################### \n",
" # validate the model #\n",
Expand All @@ -430,12 +430,12 @@
" # calculate the loss\n",
" loss = criterion(output, target)\n",
" # update running validation loss \n",
" valid_loss += loss.item()*data.size(0)\n",
" valid_loss += loss.item()\n",
" \n",
" # print training/validation statistics \n",
" # calculate average loss over an epoch\n",
" train_loss = train_loss/len(train_loader.dataset)\n",
" valid_loss = valid_loss/len(valid_loader.dataset)\n",
" train_loss = train_loss/len(train_loader)\n",
" valid_loss = valid_loss/len(valid_loader)\n",
" \n",
" print('Epoch: {} \\tTraining Loss: {:.6f} \\tValidation Loss: {:.6f}'.format(\n",
" epoch+1, \n",
Expand Down