Replace model.forward() with model() #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per pytorch documentation use of model.forward is discouraged. https://discuss.pytorch.org/t/any-different-between-model-input-and-model-forward-input/3690
As per pytorch documentation use of model.forward is discouraged. https://discuss.pytorch.org/t/any-different-between-model-input-and-model-forward-input/3690
mcleonard
approved these changes
Nov 20, 2018
Contributor
mcleonard
left a comment
mcleonard
left a comment
There was a problem hiding this comment.
Thanks for the feedback. We're not using any hooks here so it shouldn't matter much, but you're right that it is better practice to call the module/model directly instead of the forward method.
GedasGa
pushed a commit
to GedasGa/deep-learning-v2-pytorch
that referenced
this pull request
Mar 24, 2019
Replace model.forward() with model()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per pytorch documentation, use of model.forward is discouraged:
Also see:
https://discuss.pytorch.org/t/any-different-between-model-input-and-model-forward-input/3690