fix: map Convex table names to Better Auth model keys in isUniqueField #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where isUniqueField tries to access the Better Auth schema using Convex table names (e.g., "users") directly, but the schema object uses Better Auth's internal model names as keys (e.g., "user"). This causes the error: "Cannot read properties of undefined (reading 'fields')" The fix maps Convex table names to Better Auth internal model names by finding the key where betterAuthSchema[key].modelName === model, ensuring compatibility with custom modelName values in Better Auth configuration.
🦋 Changeset detectedLatest commit: e7c102d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
isUniqueFieldfunction tries to access the Better Auth schema using Convex table names (e.g.,"users","accounts","sessions") directly, but the schema object uses Better Auth's internal model names as keys (e.g.,"user","account","session").This causes the error:
Solution
The fix maps Convex table names to Better Auth internal model names by finding the key where
betterAuthSchema[key].modelName === model, ensuring compatibility with custommodelNamevalues in Better Auth configuration.Changes
isUniqueFieldfunction insrc/adapterUtils.tsto correctly map model namesmodelSchema?.fieldsTesting
This fix is based on how
@convex-dev/better-auth@0.9.7correctly handles model name mapping, ensuring compatibility with custommodelNamevalues in Better Auth configuration.Fixes the issue where unique field checks fail when Better Auth schema uses different model names than Convex table names.