fix: support scoped package #13
Merged
+20
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhyo
reviewed
Aug 15, 2023
src/core/checkSymbolmportability.ts
Outdated
| } | ||
| const lookupResult = lookupPackageJson(importerFilename); | ||
| if (lookupResult !== null) { | ||
| if (moduleSpecifier.startsWith(lookupResult.packageJson.name)) { |
There was a problem hiding this comment.
👀 This might lead to a false negative, e.g. when lookupResult.packageJson.name === "@uhyo/project" and moduleSpecifier === "@uhyo/project2".
Also I would like to keep lookupPackageJson guarded with the RegExp check in order to reduce file system access.
There was a problem hiding this comment.
Apologies for ignoring the original intention of regex! I've made the corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. thank you for the release of
treatSelfReferenceAs!However, I found that it doesn't work well when given package name is scoped (like
@vanilla-extract/css).