This repository was archived by the owner on Sep 7, 2018. It is now read-only.
Use typings for definition management #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ var ts = require('gulp-typescript'); | |||
| var tslint = require('gulp-tslint'); | |||
|
|
|||
| gulp.task('ts-build', function () { | |||
| return gulp.src(['at-*.ts', 'ts/**/*.d.ts', 'test/**/*.ts']).pipe(ts({ | |||
| return gulp.src(['at-*.ts', '*.d.ts', 'typings/**/*.d.ts', 'test/**/*.ts']).pipe(ts({ | |||
There was a problem hiding this comment.
Not sure how you wanted to include extend.d.ts in the gulp build process now that it's out of ts and at the project root. I opted for a wildcard to grab all definition files at the root, but we could change this if you have something better in mind.
There was a problem hiding this comment.
I think that we should grab only one file from typings - the one that acts as ToC… But I know typings is changing very fast and I may be wrong.
You can try with a a wildcard to grab all definition files at the root but I think that it is not future-proof way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use
typingsto manage external definitions for dependent libraries.Only breaking change was:
error TS2420: Class 'Resource' incorrectly implements interface 'IResource<Resource>'This is because the
IResourceinterface was updated.The fix was simple and can be seen here.